Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 405803002: Revert 284322 "Allow EmbedRoot to be called multiple times." (Closed)

Created:
6 years, 5 months ago by Ben Goodger (Google)
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 284322 "Allow EmbedRoot to be called multiple times." > Allow EmbedRoot to be called multiple times. > > Subsequent calls to EmbedRoot are now delegated to the window manager. This allows an application that was not created via the embed flow to obtain a connection to the view manager by asking the view manager init service to embed it somewhere. The init service just forwards this to the window manager. This is effectively like asking the window manager to create a toplevel window. > > R=sky@chromium.org > BUG=none > > Review URL: https://codereview.chromium.org/403083002 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -80 lines) Patch
M trunk/src/mojo/examples/window_manager/window_manager.cc View 5 chunks +5 lines, -10 lines 0 comments Download
M trunk/src/mojo/mojo_services.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 4 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 4 chunks +7 lines, -11 lines 0 comments Download
A + trunk/src/mojo/services/public/cpp/view_manager/view_event_dispatcher.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/mojo/services/public/cpp/view_manager/view_manager.h View 2 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/mojo/services/public/interfaces/view_manager/view_manager.mojom View 2 chunks +4 lines, -19 lines 0 comments Download
M trunk/src/mojo/services/view_manager/root_node_manager.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M trunk/src/mojo/services/view_manager/test_change_tracker.h View 3 chunks +0 lines, -3 lines 0 comments Download
M trunk/src/mojo/services/view_manager/test_change_tracker.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M trunk/src/mojo/services/view_manager/view_manager_init_service_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M trunk/src/mojo/services/view_manager/view_manager_unittest.cc View 3 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
6 years, 5 months ago (2014-07-19 06:19:50 UTC) #1
Ben Goodger (Google)
6 years, 5 months ago (2014-07-19 06:19:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r284323 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698