Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 403083002: Allow EmbedRoot to be called multiple times. (Closed)

Created:
6 years, 5 months ago by Ben Goodger (Google)
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Allow EmbedRoot to be called multiple times. Subsequent calls to EmbedRoot are now delegated to the window manager. This allows an application that was not created via the embed flow to obtain a connection to the view manager by asking the view manager init service to embed it somewhere. The init service just forwards this to the window manager. This is effectively like asking the window manager to create a toplevel window. R=sky@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284322 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284624

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -63 lines) Patch
M mojo/examples/window_manager/window_manager.cc View 1 2 3 5 chunks +10 lines, -5 lines 0 comments Download
M mojo/mojo_services.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 4 chunks +4 lines, -3 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 1 2 3 4 chunks +11 lines, -7 lines 0 comments Download
D mojo/services/public/cpp/view_manager/view_event_dispatcher.h View 1 chunk +0 lines, -30 lines 0 comments Download
M mojo/services/public/cpp/view_manager/view_manager.h View 2 chunks +6 lines, -5 lines 0 comments Download
A mojo/services/public/cpp/view_manager/window_manager_delegate.h View 4 1 chunk +33 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 2 chunks +19 lines, -4 lines 0 comments Download
M mojo/services/view_manager/root_node_manager.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.h View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M mojo/services/view_manager/test_change_tracker.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M mojo/services/view_manager/view_manager_init_service_impl.cc View 1 2 3 1 chunk +2 lines, -5 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Ben Goodger (Google)
6 years, 5 months ago (2014-07-18 23:11:37 UTC) #1
sky
LGTM https://codereview.chromium.org/403083002/diff/20001/mojo/services/view_manager/test_change_tracker.h File mojo/services/view_manager/test_change_tracker.h (right): https://codereview.chromium.org/403083002/diff/20001/mojo/services/view_manager/test_change_tracker.h#newcode30 mojo/services/view_manager/test_change_tracker.h:30: CHANGE_TYPE_EMBED_ROOT nit: add a trailing ','.
6 years, 5 months ago (2014-07-18 23:23:06 UTC) #2
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 5 months ago (2014-07-18 23:49:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/403083002/40001
6 years, 5 months ago (2014-07-18 23:51:11 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-19 00:55:29 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-19 00:58:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/30664)
6 years, 5 months ago (2014-07-19 00:58:01 UTC) #7
Ben Goodger (Google)
Committed patchset #4 manually as r284322 (presubmit successful).
6 years, 5 months ago (2014-07-19 05:17:20 UTC) #8
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 5 months ago (2014-07-21 17:56:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/403083002/80001
6 years, 5 months ago (2014-07-21 17:58:08 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 20:00:17 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 21:25:55 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/32776)
6 years, 5 months ago (2014-07-21 21:25:56 UTC) #13
Ben Goodger (Google)
6 years, 5 months ago (2014-07-22 04:27:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #5 manually as r284624 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698