Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: trunk/src/mojo/services/public/interfaces/view_manager/view_manager.mojom

Issue 405803002: Revert 284322 "Allow EmbedRoot to be called multiple times." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/mojo/services/public/interfaces/view_manager/view_manager.mojom
===================================================================
--- trunk/src/mojo/services/public/interfaces/view_manager/view_manager.mojom (revision 284322)
+++ trunk/src/mojo/services/public/interfaces/view_manager/view_manager.mojom (working copy)
@@ -22,17 +22,10 @@
ILLEGAL_ARGUMENT,
};
-// ViewManagerInitService is used to grant an application a connection to the
-// ViewManager by embedding it at an approriate Node.
+// ViewManagerInitService is responsible for launching the client that controls
+// the root node. mojo::view_manager returns an instance of this. All other
+// connections are established by the client this creates.
interface ViewManagerInitService {
- // Embed the application @ |url| at an appropriate Node.
- // The first time this method is called in the lifetime of a View Manager
- // application instance, the "appropriate Node" is defined as being the
- // service root Node.
- // Subsequent times, implementation of this method is delegated to the
- // application embedded at the service root Node. This application is
- // typically referred to as the "window manager", and will have a specific
- // definition of where within its Node hierarchy to embed an unparented URL.
EmbedRoot(string url) => (bool success);
};
@@ -200,16 +193,8 @@
// removed.
OnFocusChanged(uint32 gained_focus_id, uint32 lost_focus_id);
- // TODO(sky): The following methods represent an interface between the view
- // manager and the application embedded at the service root node
- // (i.e. the window manager). These methods are not called on
- // any other clients. They should be moved to a separate interface
- // once support for derived FIFOs is landed.
+ // TODO(sky): move to separate interface when FIFO sorted out.
- // Requests the window manager create a "top level" node embedding |url|.
- EmbedRoot(string url);
-
- // Requests the view manager dispatch the event targeted at |view|.
DispatchOnViewInputEvent(uint32 view, mojo.Event event);
};

Powered by Google App Engine
This is Rietveld 408576698