Add Vibration API layout tests that inspect internal state.

Add Vibration API layout tests that inspect internal state.

Split the files according to test area.

BUG=310144
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160591

[Michael van Ouwerkerk, 2013-10-24 15:41:24]

peter as feature reviewer
others are cc'd as fyi

[Michael van Ouwerkerk, 2013-10-24 15:46:48]

On 2013/10/24 15:41:24, Michael van Ouwerkerk wrote:
> peter as feature reviewer
> others are cc'd as fyi

Note: I'm aware I should ensure correctly merge this with Kihong's patch of
earlier today: https://codereview.chromium.org/39313002/

[Peter Beverloo, 2013-10-24 17:46:58]

https://codereview.chromium.org/40443002/diff/1/LayoutTests/vibration/vibrati...
File LayoutTests/vibration/vibration-durations.html (right):

https://codereview.chromium.org/40443002/diff/1/LayoutTests/vibration/vibrati...
LayoutTests/vibration/vibration-durations.html:55:
shouldBeTrue("navigator.vibrate([-1, -1, -1])");
You could use stronger language here to indicate that these results are wrong,
but getting the right values is pending on an issue (which you'd then refer).

https://codereview.chromium.org/40443002/diff/1/LayoutTests/vibration/vibrati...
File LayoutTests/vibration/vibration-exceptions.html (right):

https://codereview.chromium.org/40443002/diff/1/LayoutTests/vibration/vibrati...
LayoutTests/vibration/vibration-exceptions.html:8: description('Tests that bad
input throws exceptions in the Vibration API.');
seems unrelated to this patch, but nice to have anyway :-).

https://codereview.chromium.org/40443002/diff/1/Source/modules/vibration/Navi...
File Source/modules/vibration/NavigatorVibration.h (right):

https://codereview.chromium.org/40443002/diff/1/Source/modules/vibration/Navi...
Source/modules/vibration/NavigatorVibration.h:56: VibrationPattern getPattern()
const { return m_pattern; }
Blink style doesn't use the "get" prefix for getters.  pattern() would work fine
here, for the internals API maybe internals.pendingVibrationPattern() would
work?

nit: very maybe an empty line above here, since methods seem to be grouped
together?

[Michael van Ouwerkerk, 2013-10-25 10:26:38]

Thanks Peter! Please take another look.

https://codereview.chromium.org/40443002/diff/1/LayoutTests/vibration/vibrati...
File LayoutTests/vibration/vibration-durations.html (right):

https://codereview.chromium.org/40443002/diff/1/LayoutTests/vibration/vibrati...
LayoutTests/vibration/vibration-durations.html:55:
shouldBeTrue("navigator.vibrate([-1, -1, -1])");
On 2013/10/24 17:46:59, Peter Beverloo wrote:
> You could use stronger language here to indicate that these results are wrong,
> but getting the right values is pending on an issue (which you'd then refer).

Done.

https://codereview.chromium.org/40443002/diff/1/LayoutTests/vibration/vibrati...
File LayoutTests/vibration/vibration-exceptions.html (right):

https://codereview.chromium.org/40443002/diff/1/LayoutTests/vibration/vibrati...
LayoutTests/vibration/vibration-exceptions.html:8: description('Tests that bad
input throws exceptions in the Vibration API.');
On 2013/10/24 17:46:59, Peter Beverloo wrote:
> seems unrelated to this patch, but nice to have anyway :-).

Oh sorry it's related as part of the split into multiple test files. I have now
deleted navigator-vibration.html. I merged Kihong's changes to that.

https://codereview.chromium.org/40443002/diff/1/Source/modules/vibration/Navi...
File Source/modules/vibration/NavigatorVibration.h (right):

https://codereview.chromium.org/40443002/diff/1/Source/modules/vibration/Navi...
Source/modules/vibration/NavigatorVibration.h:56: VibrationPattern getPattern()
const { return m_pattern; }
On 2013/10/24 17:46:59, Peter Beverloo wrote:
> Blink style doesn't use the "get" prefix for getters.  pattern() would work
fine
> here, for the internals API maybe internals.pendingVibrationPattern() would
> work?
> 
> nit: very maybe an empty line above here, since methods seem to be grouped
> together?

Done.

[Peter Beverloo, 2013-10-25 10:36:49]

lgtm. Thanks Michael!

[commit-bot: I haz the power, 2013-10-25 15:45:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/40443002/90001

[commit-bot: I haz the power, 2013-10-25 16:50:41]

Change committed as 160591