Source/modules/vibration/NavigatorVibration.h - Issue 40443002: Add Vibration API layout tests that inspect internal state.

Side by Side Diff: Source/modules/vibration/NavigatorVibration.h

Issue 40443002: Add Vibration API layout tests that inspect internal state. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Samsung Electronics	2 * Copyright (C) 2012 Samsung Electronics

3 *	3 *

4 * This library is free software; you can redistribute it and/or	4 * This library is free software; you can redistribute it and/or

5 * modify it under the terms of the GNU Library General Public	5 * modify it under the terms of the GNU Library General Public

6 * License as published by the Free Software Foundation; either	6 * License as published by the Free Software Foundation; either

7 * version 2 of the License, or (at your option) any later version.	7 * version 2 of the License, or (at your option) any later version.

8 *	8 *

9 * This library is distributed in the hope that it will be useful,	9 * This library is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 35 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
46	46

47 // Inherited from PageLifecycleObserver	47 // Inherited from PageLifecycleObserver

48 virtual void pageVisibilityChanged() OVERRIDE;	48 virtual void pageVisibilityChanged() OVERRIDE;

49 virtual void didCommitLoad(Frame*) OVERRIDE;	49 virtual void didCommitLoad(Frame*) OVERRIDE;

50	50

51 static bool vibrate(Navigator*, unsigned time);	51 static bool vibrate(Navigator*, unsigned time);

52 static bool vibrate(Navigator*, const VibrationPattern&);	52 static bool vibrate(Navigator*, const VibrationPattern&);

53 static NavigatorVibration* from(Page*);	53 static NavigatorVibration* from(Page*);

54	54

55 bool isVibrating() const { return m_isVibrating; }	55 bool isVibrating() const { return m_isVibrating; }

	56 VibrationPattern getPattern() const { return m_pattern; }
	Peter Beverloo 2013/10/24 17:46:59 Blink style doesn't use the "get" prefix for gette Blink style doesn't use the "get" prefix for getters. pattern() would work fine here, for the internals API maybe internals.pendingVibrationPattern() would work? nit: very maybe an empty line above here, since methods seem to be grouped together? Michael van Ouwerkerk 2013/10/25 10:26:39 Done. Show quoted text On 2013/10/24 17:46:59, Peter Beverloo wrote: > Blink style doesn't use the "get" prefix for getters. pattern() would work fine > here, for the internals API maybe internals.pendingVibrationPattern() would > work? > > nit: very maybe an empty line above here, since methods seem to be grouped > together? Done.
56	57

57 private:	58 private:

58 explicit NavigatorVibration(Page*);	59 explicit NavigatorVibration(Page*);

59 static const char* supplementName();	60 static const char* supplementName();

60	61

61 Timer<NavigatorVibration> m_timerStart;	62 Timer<NavigatorVibration> m_timerStart;

62 Timer<NavigatorVibration> m_timerStop;	63 Timer<NavigatorVibration> m_timerStop;

63 bool m_isVibrating;	64 bool m_isVibrating;

64 VibrationPattern m_pattern;	65 VibrationPattern m_pattern;

65 };	66 };

66	67

67 } // namespace WebCore	68 } // namespace WebCore

68	69

69 #endif // NavigatorVibration_h	70 #endif // NavigatorVibration_h

OLD	NEW