Make wrapperTypeInfo static member const in bindings classes

Make wrapperTypeInfo static member const in bindings classes

Make wrapperTypeInfo static member const in bindings classes as it can never be
altered. This allows this member to be moved from the .data section to
.data.rel.ro, which may be shared among different library instances on Android.

objdump reports that ~600 wrapperTypeInfo members are moved by this CL.

BUG=249746
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160488

[eseidel, 2013-10-24 15:36:19]

lgtm

Wow.

[Inactive, 2013-10-24 15:39:49]

digit@, see, this is an example of case where I was hoping gcc would move the
data to the .rodata section instead of .data.rel.ro.

WrapperTypeInfo looks like a POD to me although I might be wrong. Any idea why
this does not go to .rodata or why WrapperTypeInfo is not a POD?

[haraken, 2013-10-24 15:40:02]

Looks great. LGTM.

[haraken, 2013-10-24 15:42:59]

Did you grep all |wrapperTypeInfo|s in the code base?

For example, you're missing changing |wrapperTypeInfo| in
V8HTMLImageElementConstructor.h.

[Inactive, 2013-10-24 15:45:25]

On 2013/10/24 15:42:59, haraken wrote:
> Did you grep all |wrapperTypeInfo|s in the code base?
> 
> For example, you're missing changing |wrapperTypeInfo| in
> V8HTMLImageElementConstructor.h.

I did, but apparently not well enough. I will check again, thanks.

[digit1, 2013-10-24 15:52:06]

lgtm - thanks.

Chris, .rodata is for non-relocatable constant data, and this section is placed
in the shared-read-only loadable segment of the ELF binary (which also contains
.text).
Because a WrapperTypeInfo needs to be relocated at load-time, these are moved to
.data.rel.ro (a.k.a. the RELRO section).

However, this is a good thing because we are now able to share it between
processes on Android with our custom linker :)

[Inactive, 2013-10-24 15:55:49]

On 2013/10/24 15:42:59, haraken wrote:
> Did you grep all |wrapperTypeInfo|s in the code base?
> 
> For example, you're missing changing |wrapperTypeInfo| in
> V8HTMLImageElementConstructor.h.

Ok, I did miss a couple. This is fixed in Patch Set 2.

--
FYI, each wrapperTypeInfo is 32 bytes on 32bit (and 64 bytes on 64bit).
According to objbump, 600 of them are moved so about 600*32 = 19200 bytes = 18Kb
(on 32bit).

[haraken, 2013-10-24 16:00:48]

Still LGTM of course.

[commit-bot: I haz the power, 2013-10-24 16:38:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/40433002/100001

[commit-bot: I haz the power, 2013-10-24 18:03:34]

Failed to apply patch for Source/bindings/tests/results/V8TestObjectPython.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/tests/results/V8TestObjectPython.cpp
  Hunk #2 FAILED at 3282.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/bindings/tests/results/V8TestObjectPython.cpp.rej

Patch:       Source/bindings/tests/results/V8TestObjectPython.cpp
Index: Source/bindings/tests/results/V8TestObjectPython.cpp
diff --git a/Source/bindings/tests/results/V8TestObjectPython.cpp
b/Source/bindings/tests/results/V8TestObjectPython.cpp
index
bdff79e3f0a902499e74a99efcdbd9f89e9f3e5f..4e8e78aa2135d0c106330763ca53f6b4d12d9d35
100644
--- a/Source/bindings/tests/results/V8TestObjectPython.cpp
+++ b/Source/bindings/tests/results/V8TestObjectPython.cpp
@@ -86,7 +86,7 @@ void
webCoreInitializeScriptWrappableForInterface(WebCore::TestObjectPython* obj
 }
 
 namespace WebCore {
-WrapperTypeInfo V8TestObjectPython::wrapperTypeInfo = {
V8TestObjectPython::GetTemplate, V8TestObjectPython::derefObject, 0, 0, 0,
V8TestObjectPython::installPerContextEnabledPrototypeProperties, 0,
WrapperTypeObjectPrototype };
+const WrapperTypeInfo V8TestObjectPython::wrapperTypeInfo = {
V8TestObjectPython::GetTemplate, V8TestObjectPython::derefObject, 0, 0, 0,
V8TestObjectPython::installPerContextEnabledPrototypeProperties, 0,
WrapperTypeObjectPrototype };
 
 namespace TestObjectPythonV8Internal {
 
@@ -3282,7 +3282,7 @@ static const V8DOMConfiguration::AttributeConfiguration
V8TestObjectPythonAttrib
     {"nullableStringAttribute",
TestObjectPythonV8Internal::nullableStringAttributeAttributeGetterCallback,
TestObjectPythonV8Internal::nullableStringAttributeAttributeSetterCallback, 0,
0, 0, static_cast<v8::AccessControl>(v8::DEFAULT),
static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},
     {"nullableLongAttribute",
TestObjectPythonV8Internal::nullableLongAttributeAttributeGetterCallback,
TestObjectPythonV8Internal::nullableLongAttributeAttributeSetterCallback, 0, 0,
0, static_cast<v8::AccessControl>(v8::DEFAULT),
static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},
     {"testEnumAttribute",
TestObjectPythonV8Internal::testEnumAttributeAttributeGetterCallback,
TestObjectPythonV8Internal::testEnumAttributeAttributeSetterCallback, 0, 0, 0,
static_cast<v8::AccessControl>(v8::DEFAULT),
static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},
-    {"testObjectAConstructorAttribute",
TestObjectPythonV8Internal::TestObjectPythonConstructorGetter,
TestObjectPythonV8Internal::TestObjectPythonReplaceableAttributeSetterCallback,
0, 0, &V8TestObjectA::info, static_cast<v8::AccessControl>(v8::DEFAULT),
static_cast<v8::PropertyAttribute>(v8::DontEnum), 0 /* on instance */},
+    {"testObjectAConstructorAttribute",
TestObjectPythonV8Internal::TestObjectPythonConstructorGetter,
TestObjectPythonV8Internal::TestObjectPythonReplaceableAttributeSetterCallback,
0, 0, const_cast<WrapperTypeInfo*>(&V8TestObjectA::wrapperTypeInfo),
static_cast<v8::AccessControl>(v8::DEFAULT),
static_cast<v8::PropertyAttribute>(v8::DontEnum), 0 /* on instance */},
     {"eventHandlerAttribute",
TestObjectPythonV8Internal::eventHandlerAttributeAttributeGetterCallback,
TestObjectPythonV8Internal::eventHandlerAttributeAttributeSetterCallback, 0, 0,
0, static_cast<v8::AccessControl>(v8::DEFAULT),
static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},
     {"promiseAttribute",
TestObjectPythonV8Internal::promiseAttributeAttributeGetterCallback,
TestObjectPythonV8Internal::promiseAttributeAttributeSetterCallback, 0, 0, 0,
static_cast<v8::AccessControl>(v8::DEFAULT),
static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},
     {"activityLoggingAccessForAllWorldsLongAttribute",
TestObjectPythonV8Internal::activityLoggingAccessForAllWorldsLongAttributeAttributeGetterCallback,
TestObjectPythonV8Internal::activityLoggingAccessForAllWorldsLongAttributeAttributeSetterCallback,
0, 0, 0, static_cast<v8::AccessControl>(v8::DEFAULT),
static_cast<v8::PropertyAttribute>(v8::None), 0 /* on instance */},

[commit-bot: I haz the power, 2013-10-24 18:13:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/40433002/220001

[commit-bot: I haz the power, 2013-10-24 19:46:57]

Change committed as 160488

[Nils Barth (inactive), 2013-10-25 02:14:10]

On 2013/10/24 15:42:59, haraken wrote:
> Did you grep all |wrapperTypeInfo|s in the code base?

Conveniently, this is easier after the recent CL:
IDL compiler: rename WrapperTypeInfo info => wrapperTypeInfo
https://codereview.chromium.org/39393004/
(^.-)b