Source/bindings/v8/DOMWrapperMap.h - Issue 40433002: Make wrapperTypeInfo static member const in bindings classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/DOMWrapperMap.h

Issue 40433002: Make wrapperTypeInfo static member const in bindings classes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/DOMWrapperMap.h

diff --git a/Source/bindings/v8/DOMWrapperMap.h b/Source/bindings/v8/DOMWrapperMap.h

index 963b679bb97598854e198a42bfbef25b540f6ca1..53d0206f319919a6b51d2f803837dcb781d1546b 100644

--- a/Source/bindings/v8/DOMWrapperMap.h

+++ b/Source/bindings/v8/DOMWrapperMap.h

@@ -121,7 +121,7 @@ private:

template<>

inline void DOMWrapperMap<void>::makeWeakCallback(v8::Isolate* isolate, v8::Persistent<v8::Object>* wrapper, DOMWrapperMap<void>* map)

{

- WrapperTypeInfo* type = toWrapperTypeInfo(*wrapper);

+ const WrapperTypeInfo* type = toWrapperTypeInfo(*wrapper);

ASSERT(type->derefObjectFunction);

void* key = static_cast<void*>(toNative(*wrapper));

ASSERT(*(map->m_map.get(key).persistent()) == *wrapper);

« no previous file with comments | « Source/bindings/v8/CustomElementConstructorBuilder.cpp ('k') | Source/bindings/v8/NPV8Object.h » ('j') | no next file with comments »