Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 39393004: IDL compiler: rename WrapperTypeInfo info => wrapperTypeInfo (Closed)

Created:
7 years, 2 months ago by Nils Barth (inactive)
Modified:
7 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK), eseidel
Visibility:
Public.

Description

IDL compiler: rename WrapperTypeInfo info => wrapperTypeInfo |info| is used ambiguously for both PropertyCallbackInfo and WrapperTypeInfo. It can be determined from context, but it's clearer to just use different names. This answers a request of haraken: https://codereview.chromium.org/36793003/#msg4 BUG=239771 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160442

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+425 lines, -425 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 21 chunks +27 lines, -27 lines 0 comments Download
M Source/bindings/tests/results/V8Float64Array.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8Float64Array.cpp View 4 chunks +13 lines, -13 lines 0 comments Download
M Source/bindings/tests/results/V8SupportTestInterface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8SupportTestInterface.cpp View 5 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/tests/results/V8TestActiveDOMObject.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestActiveDOMObject.cpp View 7 chunks +17 lines, -17 lines 0 comments Download
M Source/bindings/tests/results/V8TestConstants.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestConstants.cpp View 4 chunks +13 lines, -13 lines 0 comments Download
M Source/bindings/tests/results/V8TestCustomAccessors.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestCustomAccessors.cpp View 4 chunks +13 lines, -13 lines 0 comments Download
M Source/bindings/tests/results/V8TestEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestEvent.cpp View 4 chunks +13 lines, -13 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventConstructor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventConstructor.cpp View 5 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 4 chunks +13 lines, -13 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.cpp View 4 chunks +13 lines, -13 lines 0 comments Download
M Source/bindings/tests/results/V8TestExtendedEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestExtendedEvent.cpp View 5 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 7 chunks +16 lines, -16 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.cpp View 4 chunks +13 lines, -13 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceImplementedAs.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp View 5 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/tests/results/V8TestMediaQueryListListener.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestMediaQueryListListener.cpp View 4 chunks +13 lines, -13 lines 0 comments Download
M Source/bindings/tests/results/V8TestNamedConstructor.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestNamedConstructor.cpp View 6 chunks +15 lines, -15 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.cpp View 5 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 8 chunks +29 lines, -29 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 4 chunks +13 lines, -13 lines 0 comments Download
M Source/bindings/tests/results/V8TestOverloadedConstructors.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestOverloadedConstructors.cpp View 8 chunks +17 lines, -17 lines 0 comments Download
M Source/bindings/tests/results/V8TestSerializedScriptValueInterface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp View 4 chunks +13 lines, -13 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 6 chunks +15 lines, -15 lines 0 comments Download
M Source/bindings/v8/CustomElementConstructorBuilder.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/DOMWrapperWorld.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/ScriptProfiler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8DOMWrapper.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8EventListenerList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8GCController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8Initializer.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/V8WindowShell.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/WorkerScriptController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8ArrayBufferCustom.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8ArrayBufferCustom.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8DataViewCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8FormDataCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8HTMLImageElementConstructor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8HTMLImageElementConstructor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8MessageChannelCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8MutationObserverCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8PromiseCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8TypedArrayCustom.h View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/custom/V8WebKitPointCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8XMLHttpRequestCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/ElementWrapperFactory.cpp.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebBindings.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
7 years, 2 months ago (2013-10-24 09:18:54 UTC) #1
haraken
rubber-stamp LGTM.
7 years, 2 months ago (2013-10-24 09:23:30 UTC) #2
Nils Barth (inactive)
On 2013/10/24 09:23:30, haraken wrote: > rubber-stamp LGTM. That's why we have tests (^.-)v
7 years, 2 months ago (2013-10-24 09:25:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/39393004/1
7 years, 2 months ago (2013-10-24 09:25:59 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-24 11:32:02 UTC) #5
Message was sent while issue was closed. 
Change committed as 160442

Powered by Google App Engine
This is Rietveld 408576698