Remove a nested config reference from the GN build.

Remove a nested config reference from the GN build.

Having "config" reference "non_test_config" does nothing. I'm
fixing the warning that will flag this. I checked and a bunch of
targets already add non_test_config, so it isn't obviously
broken otherwise.

TBR=eseidel

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178459

[jamesr, 2014-07-18 00:28:56]

lgtm

https://codereview.chromium.org/403653002/diff/1/Source/BUILD.gn
File Source/BUILD.gn (left):

https://codereview.chromium.org/403653002/diff/1/Source/BUILD.gn#oldcode35
Source/BUILD.gn:35: configs = [ ":non_test_config" ]
Is there no way to default non_test_config? I guess adding it explicitly isn't
too bad but the failure mode for forgetting (less warnings) is kind of
unfortunate.

[brettw, 2014-07-18 00:30:26]

If you want it everywhere "config" is used, you need to add the flags to
"config". If you want to be able to modify it, it needs to be in the global list
because there's no ordering constraint between any of the build files.

[brettw, 2014-07-18 00:31:15]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2014-07-18 00:31:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/brettw@chromium.org/403653002/1

[commit-bot: I haz the power, 2014-07-18 01:56:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17604)

[commit-bot: I haz the power, 2014-07-18 01:58:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 01:58:53]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[brettw, 2014-07-18 16:20:33]

TBRing eseidel for owners.

[brettw, 2014-07-18 16:20:36]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2014-07-18 16:21:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/brettw@chromium.org/403653002/1

[commit-bot: I haz the power, 2014-07-18 16:30:39]

Change committed as 178459