Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: Source/BUILD.gn

Issue 403653002: Remove a nested config reference from the GN build. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("config.gni") 5 import("config.gni")
6 if (is_clang) { 6 if (is_clang) {
7 import("//build/config/clang/clang.gni") 7 import("//build/config/clang/clang.gni")
8 } 8 }
9 9
10 visibility = "//third_party/WebKit/*" 10 visibility = "//third_party/WebKit/*"
(...skipping 14 matching lines...) Expand all
25 } 25 }
26 26
27 # config ----------------------------------------------------------------------- 27 # config -----------------------------------------------------------------------
28 28
29 config("config") { 29 config("config") {
30 include_dirs = [ ".", ".." ] 30 include_dirs = [ ".", ".." ]
31 31
32 cflags = [] 32 cflags = []
33 defines = [] 33 defines = []
34 34
35 configs = [ ":non_test_config" ]
jamesr 2014/07/18 00:28:56 Is there no way to default non_test_config? I gues
36
37 if (is_win) { 35 if (is_win) {
38 cflags += [ 36 cflags += [
39 "/wd4305", # Truncation from 'type1' to 'type2'. 37 "/wd4305", # Truncation from 'type1' to 'type2'.
40 "/wd4324", # Struct padded due to declspec(align). 38 "/wd4324", # Struct padded due to declspec(align).
41 "/wd4714", # Function marked forceinline not inlined. 39 "/wd4714", # Function marked forceinline not inlined.
42 "/wd4800", # Value forced to bool. 40 "/wd4800", # Value forced to bool.
43 "/wd4996", # Deprecated function call. 41 "/wd4996", # Deprecated function call.
44 ] 42 ]
45 } 43 }
46 44
(...skipping 26 matching lines...) Expand all
73 71
74 # The follow configs apply to all targets except for unit tests, which rely on 72 # The follow configs apply to all targets except for unit tests, which rely on
75 # static initializers. 73 # static initializers.
76 config("non_test_config") { 74 config("non_test_config") {
77 cflags = [] 75 cflags = []
78 76
79 if (is_clang) { 77 if (is_clang) {
80 cflags += [ "-Wglobal-constructors" ] 78 cflags += [ "-Wglobal-constructors" ]
81 } 79 }
82 } 80 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698