Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: runtime/vm/raw_object.h

Issue 403643002: One more iteration of PcDescriptor iterator improvement: do not copy record but access individual … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/simulator_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/raw_object.h
===================================================================
--- runtime/vm/raw_object.h (revision 38394)
+++ runtime/vm/raw_object.h (working copy)
@@ -921,11 +921,7 @@
};
// Compressed version assumes try_index is always -1 and does not store it.
- class PcDescriptorRec {
- public:
- PcDescriptorRec()
- : pc_(0), deopt_id_and_kind_(0), token_pos_(0), try_index_(0) {}
-
+ struct PcDescriptorRec {
uword pc() const { return pc_; }
void set_pc(uword value) { pc_ = value; }
@@ -957,14 +953,6 @@
deopt_id_and_kind_ = (deopt_id_and_kind_ & 0xFF) | (value << 8);
}
- void CopyTo(PcDescriptorRec* other) const {
- other->set_pc(pc());
- other->set_deopt_id(deopt_id());
- other->set_kind(kind());
- other->set_token_pos(token_pos(), false);
- other->set_try_index(try_index());
- }
-
private:
bool is_compressed() const {
return (token_pos_ & 0x1) == 1;
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/simulator_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698