runtime/vm/simulator_arm.cc - Issue 403643002: One more iteration of PcDescriptor iterator improvement: do not copy record but access individual …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/simulator_arm.cc

Issue 403643002: One more iteration of PcDescriptor iterator improvement: do not copy record but access individual … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/simulator_arm.cc

===================================================================

--- runtime/vm/simulator_arm.cc (revision 38394)

+++ runtime/vm/simulator_arm.cc (working copy)

@@ -270,13 +270,11 @@

const PcDescriptors& descriptors =

PcDescriptors::Handle(code.pc_descriptors());

PcDescriptors::Iterator iter(descriptors, RawPcDescriptors::kAnyKind);

- while (iter.HasNext()) {

- RawPcDescriptors::PcDescriptorRec rec;

- iter.NextRec(&rec);

- if (rec.pc() == pc) {

- return rec.token_pos();

- } else if ((token_pos <= 0) && (rec.pc() > pc)) {

- token_pos = rec.token_pos();

+ while (iter.MoveNext()) {

+ if (iter.Pc() == pc) {

+ return iter.TokenPos();

+ } else if ((token_pos <= 0) && (iter.Pc() > pc)) {

+ token_pos = iter.TokenPos();

}

return token_pos;

« no previous file with comments | « runtime/vm/raw_object.h ('k') | runtime/vm/stack_frame.cc » ('j') | no next file with comments »