One more iteration of PcDescriptor iterator improvement: do not copy record but access individual …

runtime/vm/raw_object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_RAW_OBJECT_H_
 #define VM_RAW_OBJECT_H_
 
 #include "platform/assert.h"
 #include "vm/globals.h"
 #include "vm/token.h"
@@ skipping 903 matching lines @@
     kOptStaticCall   = kIcCall << 1,  // Call directly to known target.
     kUnoptStaticCall = kOptStaticCall << 1,  // Call to a known target via stub.
     kClosureCall     = kUnoptStaticCall << 1,  // Closure call.
     kRuntimeCall     = kClosureCall << 1,  // Runtime call.
     kOsrEntry        = kRuntimeCall << 1,  // OSR entry point in unopt. code.
     kOther           = kOsrEntry << 1,
     kAnyKind         = 0xFF
   };
 
   // Compressed version assumes try_index is always -1 and does not store it.
-  class PcDescriptorRec {
-   public:
-    PcDescriptorRec()
-        : pc_(0), deopt_id_and_kind_(0), token_pos_(0), try_index_(0) {}
-
+  struct PcDescriptorRec {
     uword pc() const { return pc_; }
     void set_pc(uword value) { pc_ = value; }
 
     Kind kind() const {
       return static_cast<Kind>(deopt_id_and_kind_ & kAnyKind);
     }
     void set_kind(Kind kind) {
       deopt_id_and_kind_ = (deopt_id_and_kind_ & 0xFFFFFF00) | kind;
     }
 
@@ skipping 11 matching lines @@
       int32_t bit = compressed ? 0x1 : 0x0;
       token_pos_ = (value << 1) | bit;
     }
 
     intptr_t deopt_id() const { return deopt_id_and_kind_ >> 8; }
     void set_deopt_id(int32_t value) {
       ASSERT(Utils::IsInt(24, value));
       deopt_id_and_kind_ = (deopt_id_and_kind_ & 0xFF) | (value << 8);
     }
 
-    void CopyTo(PcDescriptorRec* other) const {
-      other->set_pc(pc());
-      other->set_deopt_id(deopt_id());
-      other->set_kind(kind());
-      other->set_token_pos(token_pos(), false);
-      other->set_try_index(try_index());
-    }
-
    private:
     bool is_compressed() const {
       return (token_pos_ & 0x1) == 1;
     }
 
     uword pc_;
     int32_t deopt_id_and_kind_;  // Bits 31..8 -> deopt_id, bits 7..0 kind.
     int32_t token_pos_;  // Bits 31..1 -> token_pos, bit 1 -> compressed flag;
     int16_t try_index_;
   };
@@ skipping 985 matching lines @@
   COMPILE_ASSERT(kExternalTypedDataInt8ArrayCid ==
                  kTypedDataInt8ArrayViewCid + 15);
   COMPILE_ASSERT(kByteBufferCid == kExternalTypedDataInt8ArrayCid + 14);
   COMPILE_ASSERT(kNullCid == kByteBufferCid + 1);
   return (kNullCid - kTypedDataInt8ArrayCid);
 }
 
 }  // namespace dart
 
 #endif  // VM_RAW_OBJECT_H_