Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 403173004: Avoid heap allocations with GestureEventDataPacket (Closed)

Created:
6 years, 5 months ago by jdduke (slow)
Modified:
6 years, 5 months ago
Reviewers:
sadrul, tdresser
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Avoid heap allocations with GestureEventDataPacket There are typically only a few events in a given gesture packet. Avoid heap allocating in the common case by switching from a raw vector to a StackVector. BUG=395168 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284728

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Format #

Patch Set 4 : Fix win build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -6 lines) Patch
M ui/events/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/events.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/gesture_detection/gesture_event_data_packet.h View 3 chunks +4 lines, -5 lines 0 comments Download
M ui/events/gesture_detection/gesture_event_data_packet.cc View 1 chunk +1 line, -1 line 0 comments Download
A ui/events/gesture_detection/gesture_event_data_packet_unittest.cc View 1 2 3 1 chunk +131 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jdduke (slow)
tdresser@: PTAL (didn't realize we had StackVector until today...). As a follow-up I'm planning to ...
6 years, 5 months ago (2014-07-19 14:48:31 UTC) #1
tdresser
On 2014/07/19 14:48:31, jdduke wrote: > tdresser@: PTAL (didn't realize we had StackVector until today...). ...
6 years, 5 months ago (2014-07-21 12:50:57 UTC) #2
jdduke (slow)
sadrul@: Owner review for ui/events/BUILD.gn? Thanks.
6 years, 5 months ago (2014-07-21 15:56:33 UTC) #3
tdresser
On 2014/07/21 15:56:33, jdduke wrote: > sadrul@: Owner review for ui/events/BUILD.gn? Thanks. Test LGTM.
6 years, 5 months ago (2014-07-21 16:03:00 UTC) #4
sadrul
lgtm
6 years, 5 months ago (2014-07-22 16:51:33 UTC) #5
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 5 months ago (2014-07-22 17:35:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/403173004/60001
6 years, 5 months ago (2014-07-22 17:36:53 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 18:20:09 UTC) #8
Message was sent while issue was closed.
Change committed as 284728

Powered by Google App Engine
This is Rietveld 408576698