ui/events/gesture_detection/gesture_event_data_packet.cc - Issue 403173004: Avoid heap allocations with GestureEventDataPacket

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/gesture_detection/gesture_event_data_packet.cc

Issue 403173004: Avoid heap allocations with GestureEventDataPacket (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix win build Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/events/gesture_detection/gesture_event_data_packet.cc

diff --git a/ui/events/gesture_detection/gesture_event_data_packet.cc b/ui/events/gesture_detection/gesture_event_data_packet.cc

index 09adceca475f680be985d8971be3485b54e06722..265300cc1fcdfb7bf0c137ce0e2d09b7790b464c 100644

--- a/ui/events/gesture_detection/gesture_event_data_packet.cc

+++ b/ui/events/gesture_detection/gesture_event_data_packet.cc

@@ -72,7 +72,7 @@ GestureEventDataPacket& GestureEventDataPacket::operator=(

void GestureEventDataPacket::Push(const GestureEventData& gesture) {

DCHECK_NE(ET_UNKNOWN, gesture.type());

- gestures_.push_back(gesture);

+ gestures_->push_back(gesture);

}

GestureEventDataPacket GestureEventDataPacket::FromTouch(