Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: ui/events/gesture_detection/gesture_event_data_packet.h

Issue 403173004: Avoid heap allocations with GestureEventDataPacket (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix win build Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/events/events.gyp ('k') | ui/events/gesture_detection/gesture_event_data_packet.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_EVENTS_GESTURE_DETECTION_GESTURE_EVENT_DATA_PACKET_H_ 5 #ifndef UI_EVENTS_GESTURE_DETECTION_GESTURE_EVENT_DATA_PACKET_H_
6 #define UI_EVENTS_GESTURE_DETECTION_GESTURE_EVENT_DATA_PACKET_H_ 6 #define UI_EVENTS_GESTURE_DETECTION_GESTURE_EVENT_DATA_PACKET_H_
7 7
8 #include <vector> 8 #include "base/containers/stack_container.h"
9
10 #include "ui/events/gesture_detection/gesture_detection_export.h" 9 #include "ui/events/gesture_detection/gesture_detection_export.h"
11 #include "ui/events/gesture_detection/gesture_event_data.h" 10 #include "ui/events/gesture_detection/gesture_event_data.h"
12 11
13 namespace ui { 12 namespace ui {
14 13
15 class MotionEvent; 14 class MotionEvent;
16 15
17 // Acts as a transport container for gestures created (directly or indirectly) 16 // Acts as a transport container for gestures created (directly or indirectly)
18 // by a touch event. 17 // by a touch event.
19 class GESTURE_DETECTION_EXPORT GestureEventDataPacket { 18 class GESTURE_DETECTION_EXPORT GestureEventDataPacket {
(...skipping 17 matching lines...) Expand all
37 36
38 // Factory methods for creating a packet from a particular event. 37 // Factory methods for creating a packet from a particular event.
39 static GestureEventDataPacket FromTouch(const ui::MotionEvent& touch); 38 static GestureEventDataPacket FromTouch(const ui::MotionEvent& touch);
40 static GestureEventDataPacket FromTouchTimeout( 39 static GestureEventDataPacket FromTouchTimeout(
41 const GestureEventData& gesture); 40 const GestureEventData& gesture);
42 41
43 void Push(const GestureEventData& gesture); 42 void Push(const GestureEventData& gesture);
44 43
45 const base::TimeTicks& timestamp() const { return timestamp_; } 44 const base::TimeTicks& timestamp() const { return timestamp_; }
46 const GestureEventData& gesture(size_t i) const { return gestures_[i]; } 45 const GestureEventData& gesture(size_t i) const { return gestures_[i]; }
47 size_t gesture_count() const { return gestures_.size(); } 46 size_t gesture_count() const { return gestures_->size(); }
48 GestureSource gesture_source() const { return gesture_source_; } 47 GestureSource gesture_source() const { return gesture_source_; }
49 const gfx::PointF& touch_location() const { return touch_location_; } 48 const gfx::PointF& touch_location() const { return touch_location_; }
50 const gfx::PointF& raw_touch_location() const { return raw_touch_location_; } 49 const gfx::PointF& raw_touch_location() const { return raw_touch_location_; }
51 50
52 private: 51 private:
53 GestureEventDataPacket(base::TimeTicks timestamp, 52 GestureEventDataPacket(base::TimeTicks timestamp,
54 GestureSource source, 53 GestureSource source,
55 const gfx::PointF& touch_location, 54 const gfx::PointF& touch_location,
56 const gfx::PointF& raw_touch_location); 55 const gfx::PointF& raw_touch_location);
57 56
57 enum { kTypicalMaxGesturesPerTouch = 5 };
58 base::TimeTicks timestamp_; 58 base::TimeTicks timestamp_;
59 // TODO(jdduke): This vector is in general very short. Optimize? 59 base::StackVector<GestureEventData, kTypicalMaxGesturesPerTouch> gestures_;
60 std::vector<GestureEventData> gestures_;
61 gfx::PointF touch_location_; 60 gfx::PointF touch_location_;
62 gfx::PointF raw_touch_location_; 61 gfx::PointF raw_touch_location_;
63 GestureSource gesture_source_; 62 GestureSource gesture_source_;
64 }; 63 };
65 64
66 } // namespace ui 65 } // namespace ui
67 66
68 #endif // UI_EVENTS_GESTURE_DETECTION_GESTURE_EVENT_DATA_PACKET_H_ 67 #endif // UI_EVENTS_GESTURE_DETECTION_GESTURE_EVENT_DATA_PACKET_H_
OLDNEW
« no previous file with comments | « ui/events/events.gyp ('k') | ui/events/gesture_detection/gesture_event_data_packet.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698