Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 402303002: bluetoothLowEnergy: Send onServiceAdded after all characteristics are discovered (Closed)

Created:
6 years, 5 months ago by armansito
Modified:
6 years, 5 months ago
Reviewers:
keybuk
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

bluetoothLowEnergy: Send onServiceAdded after all characteristics are discovered This CL makes the following changes: - Add support for the new "Characteristics" and "Descriptors" properties exposed under org.bluez.GattService1 and org.bluez.GattCharacteristic1, respectively. - Add device::BluetoothGattService::Observer::GattDiscoveryCompleteForService event, which gets called after the first PropertiesChanged signal is received for the "Characteristics" property of a service. - Change BluetoothLowEnergyEventRouter, so that it sends the "onServiceAdded" event not in GattServiceAdded but in GattDiscoveryCompleteForService. BUG=394537 TEST=browser_tests:BluetoothLowEnergyApiTest, device_unittests:BluetoothGattChromeOSTest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -72 lines) Patch
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc View 2 chunks +21 lines, -10 lines 0 comments Download
M chromeos/dbus/bluetooth_gatt_characteristic_client.h View 2 chunks +5 lines, -1 line 0 comments Download
M chromeos/dbus/bluetooth_gatt_characteristic_client.cc View 4 chunks +6 lines, -12 lines 0 comments Download
M chromeos/dbus/bluetooth_gatt_service_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/dbus/bluetooth_gatt_service_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_characteristic_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_bluetooth_gatt_service_client.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_gatt_chromeos_unittest.cc View 14 chunks +30 lines, -12 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_service.h View 3 chunks +10 lines, -25 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_chromeos.h View 1 chunk +4 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_chromeos.cc View 6 chunks +29 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
armansito
6 years, 5 months ago (2014-07-22 00:06:04 UTC) #1
keybuk
lgtm
6 years, 5 months ago (2014-07-22 17:57:26 UTC) #2
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 5 months ago (2014-07-22 22:16:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/402303002/1
6 years, 5 months ago (2014-07-22 22:18:21 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-23 02:07:42 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 04:08:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31222)
6 years, 5 months ago (2014-07-23 04:08:36 UTC) #7
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 5 months ago (2014-07-23 04:32:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/402303002/1
6 years, 5 months ago (2014-07-23 04:34:03 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-23 05:49:23 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 06:44:51 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31295)
6 years, 5 months ago (2014-07-23 06:44:55 UTC) #12
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 5 months ago (2014-07-23 06:45:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/402303002/1
6 years, 5 months ago (2014-07-23 06:48:11 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-23 07:44:04 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 08:27:55 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31295)
6 years, 5 months ago (2014-07-23 08:27:56 UTC) #17
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 5 months ago (2014-07-23 16:45:35 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/402303002/1
6 years, 5 months ago (2014-07-23 16:47:04 UTC) #19
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 16:49:19 UTC) #20
Message was sent while issue was closed.
Change committed as 284955

Powered by Google App Engine
This is Rietveld 408576698