Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chromeos/dbus/bluetooth_gatt_characteristic_client.cc

Issue 402303002: bluetoothLowEnergy: Send onServiceAdded after all characteristics are discovered (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/bluetooth_gatt_characteristic_client.h ('k') | chromeos/dbus/bluetooth_gatt_service_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/bluetooth_gatt_characteristic_client.cc
diff --git a/chromeos/dbus/bluetooth_gatt_characteristic_client.cc b/chromeos/dbus/bluetooth_gatt_characteristic_client.cc
index 823a101d176400ce630186bb16acb5d9b6e6f921..45cae145d397f2b0212e7154484ef245179e4fd3 100644
--- a/chromeos/dbus/bluetooth_gatt_characteristic_client.cc
+++ b/chromeos/dbus/bluetooth_gatt_characteristic_client.cc
@@ -13,15 +13,6 @@
namespace chromeos {
-namespace {
-
-// TODO(armansito): Move these to service_constants.h later.
-const char kNotifyingProperty[] = "Notifying";
-const char kStartNotify[] = "StartNotify";
-const char kStopNotify[] = "StopNotify";
-
-} // namespace
-
// static
const char BluetoothGattCharacteristicClient::kNoResponseError[] =
"org.chromium.Error.NoResponse";
@@ -36,8 +27,11 @@ BluetoothGattCharacteristicClient::Properties::Properties(
: dbus::PropertySet(object_proxy, interface_name, callback) {
RegisterProperty(bluetooth_gatt_characteristic::kUUIDProperty, &uuid);
RegisterProperty(bluetooth_gatt_characteristic::kServiceProperty, &service);
- RegisterProperty(kNotifyingProperty, &notifying);
+ RegisterProperty(bluetooth_gatt_characteristic::kNotifyingProperty,
+ &notifying);
RegisterProperty(bluetooth_gatt_characteristic::kFlagsProperty, &flags);
+ RegisterProperty(bluetooth_gatt_characteristic::kDescriptorsProperty,
+ &descriptors);
}
BluetoothGattCharacteristicClient::Properties::~Properties() {
@@ -158,7 +152,7 @@ class BluetoothGattCharacteristicClientImpl
dbus::MethodCall method_call(
bluetooth_gatt_characteristic::kBluetoothGattCharacteristicInterface,
- kStartNotify);
+ bluetooth_gatt_characteristic::kStartNotify);
object_proxy->CallMethodWithErrorCallback(
&method_call,
@@ -184,7 +178,7 @@ class BluetoothGattCharacteristicClientImpl
dbus::MethodCall method_call(
bluetooth_gatt_characteristic::kBluetoothGattCharacteristicInterface,
- kStopNotify);
+ bluetooth_gatt_characteristic::kStopNotify);
object_proxy->CallMethodWithErrorCallback(
&method_call,
« no previous file with comments | « chromeos/dbus/bluetooth_gatt_characteristic_client.h ('k') | chromeos/dbus/bluetooth_gatt_service_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698