Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2974)

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.cc

Issue 402303002: bluetoothLowEnergy: Send onServiceAdded after all characteristics are discovered (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.cc
diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.cc b/device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.cc
index 83231b9f6511bf060ee671249cc98ca6eb8af1cd..ad15a0698e8443c080368d05c5b5121bff9878e5 100644
--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.cc
+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_chromeos.cc
@@ -341,7 +341,7 @@ void BluetoothRemoteGattCharacteristicChromeOS::GattDescriptorAdded(
GetProperties(object_path);
DCHECK(properties);
if (properties->characteristic.value() != object_path_) {
- VLOG(2) << "Remote GATT descriptor does not belong to this characteristic.";
+ VLOG(3) << "Remote GATT descriptor does not belong to this characteristic.";
return;
}
@@ -356,7 +356,6 @@ void BluetoothRemoteGattCharacteristicChromeOS::GattDescriptorAdded(
DCHECK(service_);
service_->NotifyDescriptorAddedOrRemoved(this, descriptor, true /* added */);
- service_->NotifyServiceChanged();
}
void BluetoothRemoteGattCharacteristicChromeOS::GattDescriptorRemoved(
@@ -374,12 +373,10 @@ void BluetoothRemoteGattCharacteristicChromeOS::GattDescriptorRemoved(
DCHECK(descriptor->object_path() == object_path);
descriptors_.erase(iter);
- service_->NotifyDescriptorAddedOrRemoved(this, descriptor, false /* added */);
- delete descriptor;
-
DCHECK(service_);
+ service_->NotifyDescriptorAddedOrRemoved(this, descriptor, false /* added */);
- service_->NotifyServiceChanged();
+ delete descriptor;
}
void BluetoothRemoteGattCharacteristicChromeOS::OnValueSuccess(
« no previous file with comments | « device/bluetooth/bluetooth_gatt_service.h ('k') | device/bluetooth/bluetooth_remote_gatt_service_chromeos.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698