Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1586)

Unified Diff: chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc

Issue 402293002: Experience sampling instrumentation for dangerous downloads warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sampling-api
Patch Set: Address reviewer comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc
diff --git a/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc b/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc
index 77c411a5e351a72a985d32b9ec70bfb7a2ed3fb0..212a3744085cda9af8aca8866ef6fe159ca1c08f 100644
--- a/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc
+++ b/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc
@@ -14,12 +14,19 @@
namespace extensions {
-// String constants for SamplingEvent.
+// String constants for user decision events.
msw 2014/08/14 01:48:33 nit: Move these comments to the header with the de
Chris Thompson 2014/08/14 15:43:44 Done.
const char ExperienceSamplingEvent::kProceed[] = "proceed";
const char ExperienceSamplingEvent::kDeny[] = "deny";
+const char ExperienceSamplingEvent::kIgnore[] = "ignore";
const char ExperienceSamplingEvent::kCancel[] = "cancel";
const char ExperienceSamplingEvent::kReload[] = "reload";
+// String constants for event names.
+const char ExperienceSamplingEvent::kEventNameMaliciousDownload[] =
+ "download_warning_malicious";
+const char ExperienceSamplingEvent::kEventNameDangerousDownload[] =
+ "download_warning_dangerous";
+
// static
scoped_ptr<ExperienceSamplingEvent> ExperienceSamplingEvent::Create(
const std::string& element_name,

Powered by Google App Engine
This is Rietveld 408576698