chrome/browser/extensions/api/experience_sampling_private/experience_sampling.h - Issue 402293002: Experience sampling instrumentation for dangerous downloads warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/experience_sampling_private/experience_sampling.h

Issue 402293002: Experience sampling instrumentation for dangerous downloads warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sampling-api

Patch Set: Address reviewer comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_danger_prompt.cc ('k') | chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc » ('j') | chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/experience_sampling_private/experience_sampling.h

diff --git a/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.h b/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.h

index e1d1ef1e6112d5535a7df9abd36286dca5699f8f..a7c3e4f8f770d29ce89d860e568aa5ca99d0ba4c 100644

--- a/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.h

+++ b/chrome/browser/extensions/api/experience_sampling_private/experience_sampling.h

@@ -22,8 +22,11 @@ class ExperienceSamplingEvent {

public:

static const char kProceed[];

static const char kDeny[];

+ static const char kIgnore[];

static const char kCancel[];

static const char kReload[];

+ static const char kEventNameMaliciousDownload[];

msw 2014/08/14 01:48:33 nit: Maybe add a blank line between these and the

Chris Thompson 2014/08/14 15:43:44 Done.

+ static const char kEventNameDangerousDownload[];

static scoped_ptr<ExperienceSamplingEvent> Create(

const std::string& element_name,