Experience sampling instrumentation for dangerous downloads warnings

chrome/browser/extensions/api/experience_sampling_private/experience_sampling.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/experience_sampling_private/experience_sampling.h"
 
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/common/extensions/api/experience_sampling_private.h"
 #include "extensions/browser/event_router.h"
 #include "url/gurl.h"
 
 namespace extensions {
 
-// String constants for SamplingEvent.
+// String constants for user decision events.

[msw, 2014/08/14 01:48:33]

nit: Move these comments to the header with the decls.

[Chris Thompson, 2014/08/14 15:43:44]

Done.

 const char ExperienceSamplingEvent::kProceed[] = "proceed";
 const char ExperienceSamplingEvent::kDeny[] = "deny";
+const char ExperienceSamplingEvent::kIgnore[] = "ignore";
 const char ExperienceSamplingEvent::kCancel[] = "cancel";
 const char ExperienceSamplingEvent::kReload[] = "reload";
 
+// String constants for event names.
+const char ExperienceSamplingEvent::kEventNameMaliciousDownload[] =
+    "download_warning_malicious";
+const char ExperienceSamplingEvent::kEventNameDangerousDownload[] =
+    "download_warning_dangerous";
+
 // static
 scoped_ptr<ExperienceSamplingEvent> ExperienceSamplingEvent::Create(
     const std::string& element_name,
     const GURL& destination,
     const GURL& referrer) {
   Profile* profile = NULL;
   if (g_browser_process->profile_manager())
      profile = g_browser_process->profile_manager()->GetLastUsedProfile();
   if (!profile)
     return scoped_ptr<ExperienceSamplingEvent>();
@@ skipping 54 matching lines @@
   scoped_ptr<base::ListValue> args(new base::ListValue());
   args->Append(ui_element_.ToValue().release());
   scoped_ptr<Event> event(new Event(
       api::experience_sampling_private::OnDisplayed::kEventName, args.Pass()));
   EventRouter* router = EventRouter::Get(browser_context_);
   if (router)
     router->BroadcastEvent(event.Pass());
 }
 
 }  // namespace extensions