Issue 401863003: Merge 279991 "[Android] Select text when stylus first button is ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 401863003: Merge 279991 "[Android] Select text when stylus first button is ..." (Closed)

Created:
6 years, 5 months ago by jdduke (slow)

Modified:
6 years, 5 months ago

Reviewers:
Changwan Ryu

CC:
chromium-reviews, yusukes+watch_chromium.org, tdresser+watch_chromium.org, jam, penghuang+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, jdduke+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1985_122/src/

Visibility:
Public.

More Reviews

Description

Merge 279991 "[Android] Select text when stylus first button is ..." > [Android] Select text when stylus first button is pressed. > > BUG=384803 > > Review URL: https://codereview.chromium.org/342633003 TBR=changwan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284127

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -3 lines)			Patch
M	content/browser/android/content_view_core_impl.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/android/content_view_core_impl.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A +	content/browser/renderer_host/input/gesture_text_selector.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	content/browser/renderer_host/input/gesture_text_selector.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	content/browser/renderer_host/input/gesture_text_selector_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_android.h	View	4 chunks	+11 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_android.cc	View	4 chunks	+26 lines, -0 lines	0 comments	Download
M	content/content_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/content_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	ui/events/BUILD.gn	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/events/events.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/events/gesture_detection/gesture_provider_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/events/gesture_detection/touch_disposition_gesture_filter_unittest.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	ui/events/gesture_detection/velocity_tracker_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
A +	ui/events/test/mock_motion_event.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/events/test/mock_motion_event.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r284127.

Expand Messages | Collapse Messages