Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 401633002: Enable custom suffixes for Mac bundles.

Created:
5 years, 2 months ago by jsartisohn
Modified:
5 years, 1 month ago
Reviewers:
Mark Mentovai, Nico, scottmg
CC:
gyp-developer_googlegroups.com, cschiemann_google.com
Visibility:
Public.

Description

Enable custom suffixes for Mac bundles.

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -2 lines) Patch
M pylib/gyp/xcodeproj_file.py View 1 chunk +2 lines, -2 lines 0 comments Download
A test/mac/gyptest-loadable-module-bundle-product-extension.py View 1 2 1 chunk +28 lines, -0 lines 1 comment Download
A test/mac/loadable-module-bundle-product-extension/src.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
A test/mac/loadable-module-bundle-product-extension/test.gyp View 1 2 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
jsartisohn
Can someone of the gyp reviewers pleasse comment on this issue, whether Mac bundles are ...
5 years, 2 months ago (2014-07-17 14:11:53 UTC) #1
jsartisohn
Added some random reviewers, because no one replied to this review up until now.
5 years, 1 month ago (2014-07-24 13:31:59 UTC) #2
Mark Mentovai
Can you add a test?
5 years, 1 month ago (2014-07-24 13:44:13 UTC) #3
jsartisohn
On 2014/07/24 13:44:13, Mark Mentovai wrote: > Can you add a test? You mean a ...
5 years, 1 month ago (2014-07-24 13:48:16 UTC) #4
Mark Mentovai
I mean something to put in test/mac that runs when you run gyptest.py. It should ...
5 years, 1 month ago (2014-07-24 13:49:36 UTC) #5
jsartisohn
On 2014/07/24 13:49:36, Mark Mentovai wrote: > I mean something to put in test/mac that ...
5 years, 1 month ago (2014-07-24 13:50:12 UTC) #6
Nico
Does product_extension not do what you want? (Just set it to 'app.foo'.) If that doesn't ...
5 years, 1 month ago (2014-07-24 14:17:39 UTC) #7
jsartisohn
On 2014/07/24 14:17:39, Nico (away) wrote: > Does product_extension not do what you want? (Just ...
5 years, 1 month ago (2014-07-29 11:01:55 UTC) #8
Mark Mentovai
LG with these changes. https://codereview.chromium.org/401633002/diff/20001/test/mac/gyptest-loadable-module-collision.py File test/mac/gyptest-loadable-module-collision.py (right): https://codereview.chromium.org/401633002/diff/20001/test/mac/gyptest-loadable-module-collision.py#newcode1 test/mac/gyptest-loadable-module-collision.py:1: #!/usr/bin/env python The filename should ...
5 years, 1 month ago (2014-07-29 12:55:08 UTC) #9
Mark Mentovai
https://codereview.chromium.org/401633002/diff/20001/test/mac/loadable-module-collision/src.cc File test/mac/loadable-module-collision/src.cc (right): https://codereview.chromium.org/401633002/diff/20001/test/mac/loadable-module-collision/src.cc#newcode1 test/mac/loadable-module-collision/src.cc:1: // Copyright (c) 2014 Google Inc. All rights reserved. ...
5 years, 1 month ago (2014-07-29 12:55:30 UTC) #10
jsartisohn
Hope this name is more appropriate. If not pleas suggest a correction. https://codereview.chromium.org/401633002/diff/20001/test/mac/gyptest-loadable-module-collision.py File test/mac/gyptest-loadable-module-collision.py ...
5 years, 1 month ago (2014-07-29 13:37:10 UTC) #11
Mark Mentovai
LGTM
5 years, 1 month ago (2014-07-29 13:54:47 UTC) #12
jsartisohn
On 2014/07/29 13:54:47, Mark Mentovai wrote: > LGTM How does the submit process work? I ...
5 years, 1 month ago (2014-07-29 13:56:57 UTC) #13
Mark Mentovai
Committed r1957 https://codereview.chromium.org/401633002/diff/60001/test/mac/gyptest-loadable-module-bundle-product-extension.py File test/mac/gyptest-loadable-module-bundle-product-extension.py (right): https://codereview.chromium.org/401633002/diff/60001/test/mac/gyptest-loadable-module-bundle-product-extension.py#newcode21 test/mac/gyptest-loadable-module-bundle-product-extension.py:21: CHDIR = 'loadable-module-collision' I had to fix ...
5 years, 1 month ago (2014-07-29 14:02:32 UTC) #14
jsartisohn
5 years, 1 month ago (2014-07-29 14:13:29 UTC) #15
On 2014/07/29 14:02:32, Mark Mentovai wrote:
> Committed r1957
> 
>
https://codereview.chromium.org/401633002/diff/60001/test/mac/gyptest-loadabl...
> File test/mac/gyptest-loadable-module-bundle-product-extension.py (right):
> 
>
https://codereview.chromium.org/401633002/diff/60001/test/mac/gyptest-loadabl...
> test/mac/gyptest-loadable-module-bundle-product-extension.py:21: CHDIR =
> 'loadable-module-collision'
> I had to fix this line.

Meh, yea, missed that one. Thanks.

Powered by Google App Engine
This is Rietveld 408576698