test/mac/loadable-module-collision/test.gyp - Issue 401633002: Enable custom suffixes for Mac bundles.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/mac/loadable-module-collision/test.gyp

Issue 401633002: Enable custom suffixes for Mac bundles. Base URL: http://gyp.googlecode.com/svn/trunk/

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {
	Mark Mentovai 2014/07/29 12:55:08 We normally stick the copyright boilerplate in the We normally stick the copyright boilerplate in these too, I think. jsartisohn 2014/07/29 13:37:10 Done. Show quoted text On 2014/07/29 12:55:08, Mark Mentovai wrote: > We normally stick the copyright boilerplate in these too, I think. Done.
	2 'targets': [{
	Mark Mentovai 2014/07/29 12:55:08 And this scope is normally indented by +2. And this scope is normally indented by +2. jsartisohn 2014/07/29 13:37:10 Sure. Forgot to change this. Internally we don't i Show quoted text On 2014/07/29 12:55:08, Mark Mentovai wrote: > And this scope is normally indented by +2. Sure. Forgot to change this. Internally we don't indent the first level to save some horizontal space. Done.
	3 'target_name': 'test',

	4 'type': 'none',

	5 'dependencies': ['child_one', 'child_two'],

	6 }, {

	7 'target_name': 'child_one',

	8 'product_name': 'Collide',

	9 'product_extension': 'bar',

	10 'sources': ['src.cc'],

	11 'type': 'loadable_module',

	12 'mac_bundle': 1,

	13 }, {

	14 'target_name': 'child_two',

	15 'product_name': 'Collide',

	16 'product_extension': 'foo',

	17 'sources': ['src.cc'],

	18 'type': 'loadable_module',

	19 'mac_bundle': 1,

	20 }],

	21 }

	22

OLD	NEW