Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 401243005: Fix webkit_tests on Android (Closed)

Created:
6 years, 5 months ago by johnme
Modified:
6 years, 5 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Fix webkit_tests on Android Because of https://codereview.chromium.org/401883007, webkit_tests was failing with the stacktrace[1] below. This patch attempts to fix that by adding in the extra (unused) argument to android.py (which extends driver.py), mirroring the change to driver.py [1]: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/16591 The same problem[2] happened when the patch first landed[3], until it was reverted[4]. [2]: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/16610 [3]: https://codereview.chromium.org/378113003 [4]: https://codereview.chromium.org/398543005 worker/1: TypeError('start() takes exactly 3 arguments (4 given)') raised: File "/b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py", line 254, in run worker.handle(message.name, message.src, *message.args) File "/b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 245, in handle device_failed = self._run_test(test_input, test_list_name) File "/b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 288, in _run_test self._name, self._driver, test_input, stop_when_done) File "/b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 48, in run_single_test return runner.run() File "/b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 126, in run return self._run_compare_test() File "/b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 139, in _run_compare_test driver_output = self._driver.run_test(self._driver_input(), self._stop_when_done) File "/b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py", line 154, in run_test self.start(driver_input.should_run_pixel_test, driver_input.args, stdin_deadline) TBR=abarth@chromium.org,dpranke@chromium.org,thestig@chromium.org,ivandavid@chromium.org NOTRY=true NOTREECHECKS=true BUG=388517 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/port/android.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
johnme
The CQ bit was checked by johnme@chromium.org
6 years, 5 months ago (2014-07-21 14:57:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnme@chromium.org/401243005/1
6 years, 5 months ago (2014-07-21 14:57:52 UTC) #2
commit-bot: I haz the power
Change committed as 178563
6 years, 5 months ago (2014-07-21 14:58:14 UTC) #3
Dirk Pranke
lgtm. This what happens when we don't have test coverage for something in python :(. ...
6 years, 5 months ago (2014-07-21 17:03:09 UTC) #4
johnme
On 2014/07/21 17:03:09, Dirk Pranke wrote: > This what happens when we don't have test ...
6 years, 5 months ago (2014-07-21 17:09:59 UTC) #5
Dirk Pranke
6 years, 5 months ago (2014-07-21 17:13:59 UTC) #6
Message was sent while issue was closed.
On 2014/07/21 17:09:59, johnme wrote:
> On 2014/07/21 17:03:09, Dirk Pranke wrote:
> > This what happens when we don't have test coverage for something in python
:(.
> 
> Well, I guess we had test coverage to the extent that webkit_tests did start
> failing; unfortunately all the Android bots on the Blink commit queue are
> compile only (android_blink_compile_rel, android_chromium_gn_compile_rel,
> android_blink_compile_dbg), so you only get redness after the commit queue
lands
> the patch :-|

Yeah, not really what I was referring to :). I was talking about
webkit_python_tests, 
where the coverage of port/android.py is much worse than the rest of the code
base 
(not that this is your fault).

Powered by Google App Engine
This is Rietveld 408576698