Issue 401883007: Modifications to layout test framework so that it can work with browser_tests.

Issue 401883007: Modifications to layout test framework so that it can work with browser_tests. (Closed)

Created:
6 years, 5 months ago by ivandavid

Modified:
6 years, 5 months ago

Reviewers:
Lei Zhang, Dirk Pranke

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Modifications to the layout test framework so that it can use browser_tests as a driver. This is for end to end testing for print preview. BUG=388517 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178511

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+310 lines, -29 lines)			Patch
M	Tools/Scripts/webkitpy/layout_tests/port/base.py	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	Tools/Scripts/webkitpy/layout_tests/port/browser_test.py	View	2 chunks	+37 lines, -16 lines	0 comments	Download
A	Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver.py	View	1 chunk	+95 lines, -0 lines	0 comments	Download
A	Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver_unittest.py	View	1 chunk	+66 lines, -0 lines	0 comments	Download
A	Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py	View	1 chunk	+87 lines, -0 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/driver.py	View	4 chunks	+6 lines, -3 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/factory.py	View	1 chunk	+14 lines, -5 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (0 generated)

ivandavid

I made a new issue for the layout test code from this issue https://codereview.chromium.org/378113003/

6 years, 5 months ago (2014-07-19 01:27:43 UTC) #1

Dirk Pranke

On 2014/07/19 01:27:43, ivandavid wrote: > I made a new issue for the layout test ...

6 years, 5 months ago (2014-07-19 01:32:04 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivandavid@chromium.org/401883007/1

6 years, 5 months ago (2014-07-19 01:35:57 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...

6 years, 5 months ago (2014-07-19 02:48:07 UTC) #5

johnme

6 years, 5 months ago (2014-07-21 14:58:31 UTC) #7

Message was sent while issue was closed.

This broke webkit_tests on Android. I've uploaded a fix (hopefully) to
https://codereview.chromium.org/401243005