Issue 398543005: Revert of Modifications to layout test framework so that it can work with browser_tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 398543005: Revert of Modifications to layout test framework so that it can work with browser_tests. (Closed)

Created:
6 years, 5 months ago by abarth-chromium

Modified:
6 years, 5 months ago

Reviewers:
Lei Zhang, Dirk Pranke, ivandavid

CC:
blink-reviews, Dan Beam

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Revert of Modifications to layout test framework so that it can work with browser_tests. (https://codereview.chromium.org/378113003/) Reason for revert: Might have broken a number of LayoutTests. Original issue's description: > Modifications to layout test framework so that it can work with browsertests. This is for end to end testing for print preview. > > BUG=388517 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178486 TBR=dpranke@chromium.org,thestig@chromium.org,ivandavid@chromium.org NOTREECHECKS=true NOTRY=true BUG=388517 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178492

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -342 lines)			Patch
M	Tools/Scripts/webkitpy/layout_tests/port/base.py	View	1 chunk	+1 line, -1 line	0 comments	Download
D	Tools/Scripts/webkitpy/layout_tests/port/browser_test.py	View	1 chunk	+0 lines, -67 lines	0 comments	Download
D	Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver.py	View	1 chunk	+0 lines, -97 lines	0 comments	Download
D	Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver_unittest.py	View	1 chunk	+0 lines, -66 lines	0 comments	Download
D	Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py	View	1 chunk	+0 lines, -87 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/driver.py	View	4 chunks	+3 lines, -6 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/factory.py	View	1 chunk	+5 lines, -14 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

Created Revert of Modifications to layout test framework so that it can work with browser_tests.

6 years, 5 months ago (2014-07-18 22:37:35 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/398543005/1

6 years, 5 months ago (2014-07-18 22:38:38 UTC) #2

Message was sent while issue was closed.

Change committed as 178492