Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 401163002: Fix exceptions when running the tests. (Closed)

Created:
6 years, 5 months ago by ojan
Modified:
6 years, 5 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Fix exceptions when running the tests. -Make NetworkSimulator error when runTest calls are nested. -Harden NetworkSimulator against exceptions. -Fix incorrect nested runTest call in treestatus_unittests.js. -Fix network requests in ct-results-by-builder-tests.html. This exposes that some of the tests were not overriding net and thus the tests now do a ton of network requests. This will go away when https://codereview.chromium.org/402603007 lands, so it doesn't seem worth the effort to fix all the broken cases. NOTRY=true R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178529

Patch Set 1 #

Total comments: 1

Patch Set 2 : rename function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -27 lines) Patch
M Tools/GardeningServer/scripts/net_unittests.js View 1 2 chunks +34 lines, -11 lines 0 comments Download
M Tools/GardeningServer/scripts/treestatus_unittests.js View 2 chunks +6 lines, -8 lines 0 comments Download
M Tools/GardeningServer/ui/ct-results-by-builder-tests.html View 1 chunk +14 lines, -8 lines 0 comments Download
M Tools/GardeningServer/ui/ct-results-detail.html View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ojan
This depends on https://codereview.chromium.org/400423002.
6 years, 5 months ago (2014-07-20 06:51:23 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/401163002/diff/1/Tools/GardeningServer/scripts/net_unittests.js File Tools/GardeningServer/scripts/net_unittests.js (right): https://codereview.chromium.org/401163002/diff/1/Tools/GardeningServer/scripts/net_unittests.js#newcode44 Tools/GardeningServer/scripts/net_unittests.js:44: function all_resolved(results) { allResolved ?
6 years, 5 months ago (2014-07-20 16:56:17 UTC) #2
ojan
6 years, 5 months ago (2014-07-20 18:16:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r178529 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698