Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: Tools/GardeningServer/ui/ct-results-by-builder-tests.html

Issue 401163002: Fix exceptions when running the tests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rename function Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <!-- 1 <!--
2 Copyright 2014 The Chromium Authors. All rights reserved. 2 Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. 4 found in the LICENSE file.
5 --> 5 -->
6 6
7 <link rel="import" href="ct-results-by-builder.html"> 7 <link rel="import" href="ct-results-by-builder.html">
8 8
9 <script> 9 <script>
10 (function () { 10 (function () {
(...skipping 17 matching lines...) Expand all
28 "has_stderr": true 28 "has_stderr": true
29 } 29 }
30 }, 30 },
31 "oldestFailingRevision": 177164, 31 "oldestFailingRevision": 177164,
32 "newestPassingRevision": 177165 32 "newestPassingRevision": 177165
33 }; 33 };
34 34
35 module("ct-results-by-builder"); 35 module("ct-results-by-builder");
36 36
37 asyncTest("basic", 11, function() { 37 asyncTest("basic", 11, function() {
38 var results = document.createElement('ct-results-by-builder'); 38 // FIXME: Remove this override when ct-results-detail is fixed to not use
39 // results.fetchResultsURLs.
40 var oldFetchResultsURLs = results.fetchResultsURLs;
41 results.fetchResultsURLs = function() { return Promise.resolve([]); };
39 42
40 results.failure = kExampleFailure; 43 var resultsByBuilder = document.createElement('ct-results-by-builder');
44 resultsByBuilder.failure = kExampleFailure;
41 45
42 Platform.endOfMicrotask(function() { 46 requestAnimationFrame(function() {
43 var tabs = results.shadowRoot.querySelectorAll('paper-tab'); 47 var tabs = resultsByBuilder.shadowRoot.querySelectorAll('paper-tab');
44 equal(tabs.length, 2); 48 equal(tabs.length, 2);
45 equal(tabs[0].textContent, 'Linux (dbg)'); 49 equal(tabs[0].textContent, 'Linux (dbg)');
46 equal(tabs[1].textContent, 'Mac10.6 (dbg)'); 50 equal(tabs[1].textContent, 'Mac10.6 (dbg)');
47 51
48 var detail = results.shadowRoot.querySelectorAll('ct-results-detail'); 52 var detail = resultsByBuilder.shadowRoot.querySelectorAll('ct-results-detail ');
49 equal(detail.length, 1); 53 equal(detail.length, 1);
50 equal(detail[0].test, 'inspector/console/console-viewport-selection.html'); 54 equal(detail[0].test, 'inspector/console/console-viewport-selection.html');
51 equal(detail[0].builder, 'WebKit Linux (dbg)'); 55 equal(detail[0].builder, 'WebKit Linux (dbg)');
52 equal(detail[0].result, 'TEXT'); 56 equal(detail[0].result, 'TEXT');
53 57
54 results.shadowRoot.querySelector('paper-tabs').selected = 1; 58 resultsByBuilder.shadowRoot.querySelector('paper-tabs').selected = 1;
55 59
56 Platform.endOfMicrotask(function() { 60 requestAnimationFrame(function() {
57 var detail = results.shadowRoot.querySelectorAll('ct-results-detail'); 61 results.fetchResultsURLs = oldFetchResultsURLs;
62
63 var detail = resultsByBuilder.shadowRoot.querySelectorAll('ct-results-deta il');
58 equal(detail.length, 1); 64 equal(detail.length, 1);
59 equal(detail[0].test, 'inspector/console/console-viewport-selection.html') ; 65 equal(detail[0].test, 'inspector/console/console-viewport-selection.html') ;
60 equal(detail[0].builder, 'WebKit Mac10.6 (dbg)'); 66 equal(detail[0].builder, 'WebKit Mac10.6 (dbg)');
61 equal(detail[0].result, 'IMAGE'); 67 equal(detail[0].result, 'IMAGE');
62 68
63 start(); 69 start();
64 }); 70 });
65 }); 71 });
66 }); 72 });
67 73
68 })() 74 })()
69 </script> 75 </script>
OLDNEW
« no previous file with comments | « Tools/GardeningServer/scripts/treestatus_unittests.js ('k') | Tools/GardeningServer/ui/ct-results-detail.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698