Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 400423002: Remove base.* methods. (Closed)

Created:
6 years, 5 months ago by ojan
Modified:
6 years, 5 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Remove base.* methods. -Replace some methods with sugarjs equivalents (e.g. endsWith and unique). -For methods that are only used in one place, move them to the module they're used in. These and almost all the code left in the scripts directory will all go away with https://codereview.chromium.org/402603007. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -339 lines) Patch
M Tools/GardeningServer/run-unittests.html View 1 chunk +0 lines, -1 line 0 comments Download
M Tools/GardeningServer/scripts/base.js View 2 chunks +0 lines, -107 lines 0 comments Download
D Tools/GardeningServer/scripts/base_unittests.js View 1 chunk +0 lines, -210 lines 0 comments Download
M Tools/GardeningServer/scripts/config.js View 1 chunk +1 line, -1 line 0 comments Download
M Tools/GardeningServer/scripts/net.js View 2 chunks +16 lines, -1 line 0 comments Download
M Tools/GardeningServer/scripts/net_unittests.js View 1 chunk +8 lines, -1 line 0 comments Download
M Tools/GardeningServer/scripts/results.js View 6 chunks +51 lines, -13 lines 0 comments Download
M Tools/GardeningServer/scripts/results_unittests.js View 3 chunks +68 lines, -2 lines 0 comments Download
M Tools/GardeningServer/scripts/svn-log.js View 1 chunk +13 lines, -1 line 0 comments Download
M Tools/GardeningServer/scripts/svn-log_unittests.js View 1 chunk +8 lines, -0 lines 0 comments Download
M Tools/GardeningServer/ui/ct-results-detail-tests.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ojan
Depends on https://codereview.chromium.org/405853002.
6 years, 5 months ago (2014-07-20 05:14:58 UTC) #1
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-20 16:54:41 UTC) #2
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 5 months ago (2014-07-20 18:05:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/400423002/1
6 years, 5 months ago (2014-07-20 18:06:43 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-20 18:07:18 UTC) #5
Message was sent while issue was closed.
Change committed as 178528

Powered by Google App Engine
This is Rietveld 408576698