Resolve screen.orientation.lock() promise with undefined.

Resolve screen.orientation.lock() promise with undefined.

This is following the current state of the specification.

BUG=162827
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178406

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178433

[Michael van Ouwerkerk, 2014-07-17 16:56:24]

lgtm with nit

https://codereview.chromium.org/400703003/diff/1/public/platform/WebLockOrien...
File public/platform/WebLockOrientationCallback.h (right):

https://codereview.chromium.org/400703003/diff/1/public/platform/WebLockOrien...
public/platform/WebLockOrientationCallback.h:26: virtual void onSuccess() = 0;
These being pure virtual makes modifying the interface more painful. Is this
necessary?

[abarth-chromium, 2014-07-17 18:08:46]

lgtm

https://codereview.chromium.org/400703003/diff/1/public/platform/WebLockOrien...
File public/platform/WebLockOrientationCallback.h (right):

https://codereview.chromium.org/400703003/diff/1/public/platform/WebLockOrien...
public/platform/WebLockOrientationCallback.h:26: virtual void onSuccess() = 0;
They don't have to be pure virtual.

[mlamouri (slow - plz ping), 2014-07-17 19:21:40]

https://codereview.chromium.org/400703003/diff/1/public/platform/WebLockOrien...
File public/platform/WebLockOrientationCallback.h (right):

https://codereview.chromium.org/400703003/diff/1/public/platform/WebLockOrien...
public/platform/WebLockOrientationCallback.h:26: virtual void onSuccess() = 0;
On 2014/07/17 18:08:46, abarth wrote:
> They don't have to be pure virtual.

It seems less pure with regard to design and doesn't change much given that this
interface is implemented by LockOrientationCallback which lives in Blink too.
The issue is that onSuccess(angle,type) is called from Chromium so I need to
change the Chromium side before updating the interface.

Unless I'm missing the point you guys were raising?

[abarth-chromium, 2014-07-17 20:06:29]

On 2014/07/17 at 19:21:40, mlamouri wrote:
> Unless I'm missing the point you guys were raising?

I wasn't intending to raise a point, I was just answering  mvanouwerkerk's
question.

[mlamouri (slow - plz ping), 2014-07-17 22:51:46]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-07-17 22:52:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/400703003/1

[commit-bot: I haz the power, 2014-07-17 23:27:47]

Change committed as 178406

[alancutter (OOO until 2018), 2014-07-18 00:07:56]

A revert of this CL has been created in
https://codereview.chromium.org/400623004/ by alancutter@chromium.org.

The reason for reverting is: Chromium unit tests fail to compile with this patch
on Windows.

http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/58418

Compilation error:
FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc
"C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo
/showIncludes /FC
@obj\content\renderer\screen_orientation\content_unittests.screen_orientation_dispatcher_unittest.obj.rsp
/c
..\..\content\renderer\screen_orientation\screen_orientation_dispatcher_unittest.cc
/Foobj\content\renderer\screen_orientation\content_unittests.screen_orientation_dispatcher_unittest.obj
/Fdobj\content\content_unittests.cc.pdb 
c:\b\build\slave\win-latest-rel\build\src\content\renderer\screen_orientation\screen_orientation_dispatcher_unittest.cc(121)
:error C2259: 'content::MockLockOrientationCallback' : cannot instantiate
abstract class
        due to following members:
        'void blink::WebLockOrientationCallback::onSuccess(void)' : is abstract
       
c:\b\build\slave\win-latest-rel\build\src\third_party\webkit\public\platform\weblockorientationcallback.h(26)
: see declaration of 'blink::WebLockOrientationCallback::onSuccess'
.

[mlamouri (slow - plz ping), 2014-07-18 10:06:53]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-07-18 10:07:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/400703003/20001

[commit-bot: I haz the power, 2014-07-18 11:19:25]

Change committed as 178433