Resolve screen.orientation.lock() promise with undefined.

public/platform/WebLockOrientationCallback.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WebLockOrientationCallback_h
 #define WebLockOrientationCallback_h
 
 #include "public/platform/WebLockOrientationError.h"
 #include "public/platform/WebScreenOrientationType.h"
 
 namespace blink {
 
 // WebScreenOrientationType is an interface to be used by the embedder in order
 // to inform Blink when a screen lock operation has succeeded or failed.
 // A success notification comes with the new orientation angle and orientation
 // type and a failure notification comes with an information about the type of
 // failure.
 class WebLockOrientationCallback {
 public:
     virtual ~WebLockOrientationCallback() { }
 
-    virtual void onSuccess(unsigned angle, WebScreenOrientationType) = 0;
+    virtual void onSuccess(unsigned angle, WebScreenOrientationType)
+    {
+        onSuccess();
+    }
+    virtual void onSuccess() = 0;

[Michael van Ouwerkerk, 2014/07/17 16:56:24]

These being pure virtual makes modifying the interface more painful. Is this
necessary?

[abarth-chromium, 2014/07/17 18:08:46]

They don't have to be pure virtual.

[mlamouri (slow - plz ping), 2014/07/17 19:21:39]

It seems less pure with regard to design and doesn't change much given that this
interface is implemented by LockOrientationCallback which lives in Blink too.
The issue is that onSuccess(angle,type) is called from Chromium so I need to
change the Chromium side before updating the interface.

Unless I'm missing the point you guys were raising?

     virtual void onError(WebLockOrientationError) = 0;
 };
 
 } // namespace blink
 
 #endif // WebLockOrientationCallback_h