public/platform/WebLockOrientationCallback.h - Issue 400703003: Resolve screen.orientation.lock() promise with undefined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebLockOrientationCallback.h

Issue 400703003: Resolve screen.orientation.lock() promise with undefined. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/platform/WebLockOrientationCallback.h

diff --git a/public/platform/WebLockOrientationCallback.h b/public/platform/WebLockOrientationCallback.h

index 73cb686635d14591ab6e4a943c90101112e74352..67f362ae774f258da28250078c43895f3e13d01a 100644

--- a/public/platform/WebLockOrientationCallback.h

+++ b/public/platform/WebLockOrientationCallback.h

@@ -19,7 +19,11 @@ class WebLockOrientationCallback {

public:

virtual ~WebLockOrientationCallback() { }

- virtual void onSuccess(unsigned angle, WebScreenOrientationType) = 0;

+ virtual void onSuccess(unsigned angle, WebScreenOrientationType)

+ {

+ onSuccess();

+ }

+ virtual void onSuccess() { }

virtual void onError(WebLockOrientationError) = 0;

};

« no previous file with comments | « Source/modules/screen_orientation/LockOrientationCallback.cpp ('k') | no next file » | no next file with comments »