Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: tools/telemetry/telemetry/value/list_of_scalar_values.py

Issue 399893003: Add "description" attribute to Value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix calls to Value constructor so that the tests pass. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/list_of_scalar_values.py
diff --git a/tools/telemetry/telemetry/value/list_of_scalar_values.py b/tools/telemetry/telemetry/value/list_of_scalar_values.py
index 210ca3255f7ae201d6968ec5ca3f582b6eab46d8..5bd95d41633d22eea97cb5513b43c8b6ec7ca58c 100644
--- a/tools/telemetry/telemetry/value/list_of_scalar_values.py
+++ b/tools/telemetry/telemetry/value/list_of_scalar_values.py
@@ -11,8 +11,10 @@ def _Mean(values):
class ListOfScalarValues(value_module.Value):
def __init__(self, page, name, units, values,
- important=True, same_page_merge_policy=value_module.CONCATENATE):
- super(ListOfScalarValues, self).__init__(page, name, units, important)
+ important=True, description=None,
+ same_page_merge_policy=value_module.CONCATENATE):
+ super(ListOfScalarValues, self).__init__(page, name, units, important,
+ description)
assert len(values) > 0
assert isinstance(values, list)
for v in values:
@@ -29,12 +31,14 @@ class ListOfScalarValues(value_module.Value):
merge_policy = 'CONCATENATE'
else:
merge_policy = 'PICK_FIRST'
- return ('ListOfScalarValues(%s, %s, %s, %s, ' +
- 'important=%s, same_page_merge_policy=%s)') % (
+ return ('ListOfScalarValues(%s, %s, %s, %s, '
+ 'important=%s, description=%s, same_page_merge_policy=%s)') % (
page_name,
- self.name, self.units,
+ self.name,
+ self.units,
repr(self.values),
self.important,
+ self.description,
merge_policy)
def GetBuildbotDataType(self, output_context):
« no previous file with comments | « tools/telemetry/telemetry/value/histogram.py ('k') | tools/telemetry/telemetry/value/list_of_string_values.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698