Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: tools/telemetry/telemetry/value/histogram.py

Issue 399893003: Add "description" attribute to Value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix calls to Value constructor so that the tests pass. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/histogram.py
diff --git a/tools/telemetry/telemetry/value/histogram.py b/tools/telemetry/telemetry/value/histogram.py
index d57f6f57c523980992e9351d94e83d0b1ce5dd3b..fa70445c7232f70c936af0d14773401521128c0e 100644
--- a/tools/telemetry/telemetry/value/histogram.py
+++ b/tools/telemetry/telemetry/value/histogram.py
@@ -27,8 +27,10 @@ class HistogramValueBucket(object):
class HistogramValue(value_module.Value):
def __init__(self, page, name, units,
- raw_value=None, raw_value_json=None, important=True):
- super(HistogramValue, self).__init__(page, name, units, important)
+ raw_value=None, raw_value_json=None, important=True,
+ description=None):
+ super(HistogramValue, self).__init__(page, name, units, important,
+ description)
if raw_value_json:
assert raw_value == None, 'Dont specify both raw_value and raw_value_json'
raw_value = json.loads(raw_value_json)
@@ -49,11 +51,13 @@ class HistogramValue(value_module.Value):
page_name = self.page.url
else:
page_name = None
- return 'HistogramValue(%s, %s, %s, raw_json_string="%s", important=%s)' % (
- page_name,
- self.name, self.units,
- self.ToJSONString(),
- self.important)
+ return ('HistogramValue(%s, %s, %s, raw_json_string="%s", '
+ 'important=%s, description=%s') % (
+ page_name,
+ self.name, self.units,
+ self.ToJSONString(),
+ self.important,
+ self.description)
def GetBuildbotDataType(self, output_context):
if self._IsImportantGivenOutputIntent(output_context):
« no previous file with comments | « tools/telemetry/telemetry/value/failure.py ('k') | tools/telemetry/telemetry/value/list_of_scalar_values.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698