Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: tools/telemetry/telemetry/value/list_of_string_values.py

Issue 399893003: Add "description" attribute to Value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix calls to Value constructor so that the tests pass. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/value/list_of_scalar_values.py ('k') | tools/telemetry/telemetry/value/scalar.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/list_of_string_values.py
diff --git a/tools/telemetry/telemetry/value/list_of_string_values.py b/tools/telemetry/telemetry/value/list_of_string_values.py
index f029279a316dc085b25e628a1c068ee5eaa4d86f..9e8566a80c2c5cf4c778afef7da30bf839e6e3a3 100644
--- a/tools/telemetry/telemetry/value/list_of_string_values.py
+++ b/tools/telemetry/telemetry/value/list_of_string_values.py
@@ -6,8 +6,10 @@ from telemetry import value as value_module
class ListOfStringValues(value_module.Value):
def __init__(self, page, name, units, values,
- important=True, same_page_merge_policy=value_module.CONCATENATE):
- super(ListOfStringValues, self).__init__(page, name, units, important)
+ important=True, description=None,
+ same_page_merge_policy=value_module.CONCATENATE):
+ super(ListOfStringValues, self).__init__(page, name, units, important,
+ description)
assert len(values) > 0
assert isinstance(values, list)
for v in values:
@@ -25,11 +27,13 @@ class ListOfStringValues(value_module.Value):
else:
merge_policy = 'PICK_FIRST'
return ('ListOfStringValues(%s, %s, %s, %s, ' +
- 'important=%s, same_page_merge_policy=%s)') % (
+ 'important=%s, description=%s, same_page_merge_policy=%s)') % (
page_name,
- self.name, self.units,
+ self.name,
+ self.units,
repr(self.values),
self.important,
+ self.description,
merge_policy)
def GetBuildbotDataType(self, output_context):
« no previous file with comments | « tools/telemetry/telemetry/value/list_of_scalar_values.py ('k') | tools/telemetry/telemetry/value/scalar.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698