tools/telemetry/telemetry/value/failure.py - Issue 399893003: Add "description" attribute to Value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/value/failure.py

Issue 399893003: Add "description" attribute to Value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix calls to Value constructor so that the tests pass. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/value/failure.py

diff --git a/tools/telemetry/telemetry/value/failure.py b/tools/telemetry/telemetry/value/failure.py

index 08e2b9e8888cd7273cea1654ee8476129dabca96..252bb22f2c454e087d301513bdf611b39adc7aea 100644

--- a/tools/telemetry/telemetry/value/failure.py

+++ b/tools/telemetry/telemetry/value/failure.py

@@ -9,7 +9,7 @@ from telemetry import value as value_module

class FailureValue(value_module.Value):

- def __init__(self, page, exc_info):

+ def __init__(self, page, exc_info, description=None):

"""A value representing a failure when running the page.

Args:

@@ -18,7 +18,7 @@ class FailureValue(value_module.Value):

this failure.

"""

exc_type = exc_info[0].__name__

- super(FailureValue, self).__init__(page, exc_type, '', True)

+ super(FailureValue, self).__init__(page, exc_type, '', True, description)

self._exc_info = exc_info

@classmethod