Issue 39973004: Minor changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 39973004: Minor changes (Closed)

Created:
7 years, 2 months ago by robertphillips

Modified:
7 years, 2 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This changes just clean things up a bit and are split off from a larger CL.

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -1 line)			Patch
M	include/gpu/GrResource.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/effects/SkBitmapAlphaThresholdShader.cpp	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/gpu/GrTexture.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Tom Hudson

On 2013/10/24 13:53:24, bsalomon wrote: > lgtm All that just so you could tune in ...

7 years, 2 months ago (2013-10-24 13:56:18 UTC) #3

robertphillips

committed as r11940 The bar has been raised with the AutoGeometryAndStatePush class.

7 years, 2 months ago (2013-10-24 14:05:44 UTC) #4

bsalomon

7 years, 2 months ago (2013-10-24 14:14:29 UTC) #5

Message was sent while issue was closed.

On 2013/10/24 13:56:18, Tom Hudson wrote:
> On 2013/10/24 13:53:24, bsalomon wrote:
> > lgtm
> 
> All that just so you could tune in next week for the same bat time, same bat
> shader?

Have you seen the image produced by the bat shader GM? It's exactly what you
think it is.

Expand Messages | Collapse Messages