chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc - Issue 399573002: [Password Generation] Trigger confirmation bubble when a password is saved

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 399573002: [Password Generation] Trigger confirmation bubble when a password is saved (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_ui_controller.cc ('K') | « chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc ('k') | chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc » ('j') | components/password_manager/core/browser/password_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

index f8f08d6fbd6dae7c821836692877af401d427336..6b9ec54be401f242f4e02fcf8fc797093ef66338 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

@@ -130,8 +130,7 @@ void ShowManagePasswordsBubble(content::WebContents* web_contents) {

ManagePasswordsUIController::FromWebContents(web_contents);

ManagePasswordsBubbleView::ShowBubble(

web_contents,

- controller->state() ==

- password_manager::ui::PENDING_PASSWORD_AND_BUBBLE_STATE

+ password_manager::ui::IsAutomaticDisplayState(controller->state())

? ManagePasswordsBubbleView::AUTOMATIC

: ManagePasswordsBubbleView::USER_ACTION);

}