[Password Generation] Trigger confirmation bubble when a password is saved

chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
index 259a517c6b6456679c0445cff55a4ec49e8fedc9..0f94dfc4d62131c54dcac16ebbf113aeea8eb7ee 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
@@ -117,7 +117,8 @@ TEST_F(ManagePasswordsUIControllerTest, PasswordSubmitted) {
 
   ManagePasswordsIconMock mock;
   controller()->UpdateIconAndBubbleState(&mock);
-  EXPECT_EQ(password_manager::ui::PENDING_PASSWORD_STATE, mock.state());
+  EXPECT_EQ(password_manager::ui::PENDING_PASSWORD_AND_BUBBLE_STATE,
+            mock.state());
 }
 
 TEST_F(ManagePasswordsUIControllerTest, PasswordSaved) {
@@ -159,7 +160,8 @@ TEST_F(ManagePasswordsUIControllerTest, QuickNavigations) {
   controller()->OnPasswordSubmitted(test_form_manager);
   ManagePasswordsIconMock mock;
   controller()->UpdateIconAndBubbleState(&mock);
-  EXPECT_EQ(password_manager::ui::PENDING_PASSWORD_STATE, mock.state());
+  EXPECT_EQ(password_manager::ui::PENDING_PASSWORD_AND_BUBBLE_STATE,
+            mock.state());
 
   // Fake-navigate within a second. We expect the bubble's state to persist
   // if a navigation occurs too quickly for a user to reasonably have been
@@ -172,7 +174,8 @@ TEST_F(ManagePasswordsUIControllerTest, QuickNavigations) {
                                      content::FrameNavigateParams());
   controller()->UpdateIconAndBubbleState(&mock);
 
-  EXPECT_EQ(password_manager::ui::PENDING_PASSWORD_STATE, mock.state());
+  EXPECT_EQ(password_manager::ui::PENDING_PASSWORD_AND_BUBBLE_STATE,
+            mock.state());
 }
 
 TEST_F(ManagePasswordsUIControllerTest, SlowNavigations) {
@@ -184,7 +187,8 @@ TEST_F(ManagePasswordsUIControllerTest, SlowNavigations) {
   controller()->OnPasswordSubmitted(test_form_manager);
   ManagePasswordsIconMock mock;
   controller()->UpdateIconAndBubbleState(&mock);
-  EXPECT_EQ(password_manager::ui::PENDING_PASSWORD_STATE, mock.state());
+  EXPECT_EQ(password_manager::ui::PENDING_PASSWORD_AND_BUBBLE_STATE,
+            mock.state());
 
   // Fake-navigate after a second. We expect the bubble's state to be reset
   // if a navigation occurs after this limit.
@@ -295,3 +299,14 @@ TEST_F(ManagePasswordsUIControllerTest, BlacklistedElsewhere) {
   controller()->UpdateIconAndBubbleState(&mock);
   EXPECT_EQ(password_manager::ui::BLACKLIST_STATE, mock.state());
 }
+
+TEST_F(ManagePasswordsUIControllerTest, ShowSaveConfirmation) {
+  password_manager::StubPasswordManagerClient client;
+  password_manager::StubPasswordManagerDriver driver;
+  scoped_ptr<password_manager::PasswordFormManager> test_form_manager(
+      new password_manager::PasswordFormManager(
+          NULL, &client, &driver, test_form(), false));
+
+  controller()->ShowSaveConfirmation(test_form_manager.Pass());
+  EXPECT_EQ(password_manager::ui::CONFIRMATION_STATE, controller()->state());
+}