[Password Generation] Trigger confirmation bubble when a password is saved

components/password_manager/core/browser/password_manager.cc

Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index 1cf87d2c9293bf54830d6d3e7c0ed46d869dd5a9..e92e8a0cbddee6e814625f81cc5f9abea103ddb1 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -459,7 +459,12 @@ void PasswordManager::OnPasswordFormsRendered(
       if (logger)
         logger->LogMessage(Logger::STRING_DECISION_SAVE);
       provisional_save_manager_->Save();
-      provisional_save_manager_.reset();
+
+      if (provisional_save_manager_->HasGeneratedPassword()) {
+        client_->ShowPasswordSaveConfirmation(provisional_save_manager_.Pass());

[Mike West, 2014/07/16 07:55:03]

'Pass()' or 'release()'? If 'Pass()' is what we mean here, please change #457 as
well.

[Garrett Casto, 2014/07/17 06:42:46]

Pass(). Being explicit about pointer ownership is good. Updated
PromptUserToSavePassword() to match.

+      } else {
+        provisional_save_manager_.reset();
+      }
     }
   }
 }