Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: tools/telemetry/telemetry/results/buildbot_page_measurement_results.py

Issue 399263003: Add FailureValue and wire it through PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update another usage of self.failures, fix unit tests. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/results/buildbot_page_measurement_results.py
diff --git a/tools/telemetry/telemetry/results/buildbot_page_measurement_results.py b/tools/telemetry/telemetry/results/buildbot_page_measurement_results.py
index fef9933830a4a2fe53d7da775a2cb73c6814061d..6e9b698da0924e652d5ac5bea9b5f297dbacd7a1 100644
--- a/tools/telemetry/telemetry/results/buildbot_page_measurement_results.py
+++ b/tools/telemetry/telemetry/results/buildbot_page_measurement_results.py
@@ -52,6 +52,9 @@ class BuildbotPageMeasurementResults(
buildbot_value = value.GetBuildbotValue()
buildbot_data_type = value.GetBuildbotDataType(
output_context=value_module.PER_PAGE_RESULT_OUTPUT_CONTEXT)
+ if buildbot_value is None or buildbot_data_type is None:
+ return
+
buildbot_measurement_name, buildbot_trace_name = (
value.GetBuildbotMeasurementAndTraceNameForPerPageResult())
self._PrintPerfResult(buildbot_measurement_name,
@@ -68,10 +71,12 @@ class BuildbotPageMeasurementResults(
buildbot_value = value.GetBuildbotValue()
buildbot_data_type = value.GetBuildbotDataType(
output_context=value_module.COMPUTED_PER_PAGE_SUMMARY_OUTPUT_CONTEXT)
+ if buildbot_value is None or buildbot_data_type is None:
+ return
+
buildbot_measurement_name, buildbot_trace_name = (
value.GetBuildbotMeasurementAndTraceNameForComputedSummaryResult(
self._trace_tag))
-
self._PrintPerfResult(buildbot_measurement_name,
buildbot_trace_name,
buildbot_value, value.units, buildbot_data_type)

Powered by Google App Engine
This is Rietveld 408576698