tools/telemetry/telemetry/results/block_page_measurement_results.py - Issue 399263003: Add FailureValue and wire it through PageTestResults.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/block_page_measurement_results.py

Issue 399263003: Add FailureValue and wire it through PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update another usage of self.failures, fix unit tests. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/record_wpr.py ('k') | tools/telemetry/telemetry/results/buildbot_page_measurement_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/block_page_measurement_results.py

diff --git a/tools/telemetry/telemetry/results/block_page_measurement_results.py b/tools/telemetry/telemetry/results/block_page_measurement_results.py

index 7780ab31cb1ffc1affcc30751bdf22d9810f758c..b468cfab57c0340fe910fbe25343db80add9291f 100644

--- a/tools/telemetry/telemetry/results/block_page_measurement_results.py

+++ b/tools/telemetry/telemetry/results/block_page_measurement_results.py

@@ -18,10 +18,11 @@ class BlockPageMeasurementResults(

return

lines = ['name: %s' % values[0].page.display_name]

for value in sorted(values, key=lambda x: x.name):

- lines.append('%s (%s): %s' %

- (value.name,

- value.units,

- value.GetRepresentativeString()))

+ if value.GetRepresentativeString() is not None:

+ lines.append('%s (%s): %s' %

+ (value.name,

+ value.units,

+ value.GetRepresentativeString()))

for line in lines:

self._output_stream.write(line)

self._output_stream.write(os.linesep)