tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py - Issue 399263003: Add FailureValue and wire it through PageTestResults.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py

Issue 399263003: Add FailureValue and wire it through PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update another usage of self.failures, fix unit tests. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/buildbot_page_measurement_results.py ('k') | tools/telemetry/telemetry/results/gtest_test_results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py

diff --git a/tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py b/tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py

index 0be7a8ccd5fdbd49e172bb2ac46ef53c67b210d8..9080085df3f7dbbe0f65e586d718094932586f2a 100644

--- a/tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py

+++ b/tools/telemetry/telemetry/results/buildbot_page_measurement_results_unittest.py

@@ -5,11 +5,12 @@ import os

from telemetry import perf_tests_helper

from telemetry.page import page_set

+from telemetry.results import base_test_results_unittest

+from telemetry.results import buildbot_page_measurement_results

+from telemetry.value import failure

from telemetry.value import histogram

from telemetry.value import list_of_scalar_values

from telemetry.value import scalar

-from telemetry.results import base_test_results_unittest

-from telemetry.results import buildbot_page_measurement_results

def _MakePageSet():

@@ -130,7 +131,8 @@ class BuildbotPageMeasurementResultsTest(

measurement_results.AddValue(scalar.ScalarValue(

test_page_set.pages[0], 'a', 'seconds', 3))

measurement_results.DidMeasurePage()

- measurement_results.AddFailureMessage(test_page_set.pages[0], 'message')

+ measurement_results.AddValue(

+ failure.FailureValue.FromMessage(test_page_set.pages[0], 'message'))

measurement_results.WillMeasurePage(test_page_set.pages[1])

measurement_results.AddValue(scalar.ScalarValue(

@@ -161,7 +163,8 @@ class BuildbotPageMeasurementResultsTest(

measurement_results.AddValue(scalar.ScalarValue(

test_page_set.pages[1], 'a', 'seconds', 7))

measurement_results.DidMeasurePage()

- measurement_results.AddFailureMessage(test_page_set.pages[1], 'message')

+ measurement_results.AddValue(

+ failure.FailureValue.FromMessage(test_page_set.pages[1], 'message'))

measurement_results.WillMeasurePage(test_page_set.pages[0])

measurement_results.AddValue(scalar.ScalarValue(