Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 399153005: Hook up command buffer with SH_SCALARIZE_VEC_AND_MAT_CONSTRUCTOR_ARGS (Closed)

Created:
6 years, 5 months ago by Zhenyao Mo
Modified:
6 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Hook up command buffer with SH_SCALARIZE_VEC_AND_MAT_CONSTRUCTOR_ARGS BUG=393810 TEST=gpu_unittests R=kbr@chromium.org,bajones@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284764

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -21 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 3 2 chunks +35 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Zhenyao Mo
kbr, bajones: please review.
6 years, 5 months ago (2014-07-21 22:39:24 UTC) #1
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/399153005/diff/40001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/399153005/diff/40001/gpu/config/gpu_driver_bug_list_json.cc#newcode1077 gpu/config/gpu_driver_bug_list_json.cc:1077: "type": "linux" Is there any way to make ...
6 years, 5 months ago (2014-07-21 23:01:58 UTC) #2
Zhenyao Mo
https://codereview.chromium.org/399153005/diff/40001/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/399153005/diff/40001/gpu/config/gpu_driver_bug_list_json.cc#newcode1077 gpu/config/gpu_driver_bug_list_json.cc:1077: "type": "linux" On 2014/07/21 23:01:58, Ken Russell wrote: > ...
6 years, 5 months ago (2014-07-21 23:09:47 UTC) #3
bajones
lgtm
6 years, 5 months ago (2014-07-22 17:47:25 UTC) #4
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 5 months ago (2014-07-22 17:47:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/399153005/60001
6 years, 5 months ago (2014-07-22 17:48:32 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 20:40:31 UTC) #7
Message was sent while issue was closed. 
Change committed as 284764

Powered by Google App Engine
This is Rietveld 408576698