Generalize mask helper a bit for compression

Generalize mask helper a bit for compression

Committed: https://skia.googlesource.com/skia/+/b577c55a13850b8f4739e14b10d426a3ec6b05d0

[robertphillips, 2014-07-16 12:13:23]

lgtm + some clarity & comment suggestions

https://codereview.chromium.org/398603004/diff/20001/src/gpu/GrSWMaskHelper.cpp
File src/gpu/GrSWMaskHelper.cpp (right):

https://codereview.chromium.org/398603004/diff/20001/src/gpu/GrSWMaskHelper.c...
src/gpu/GrSWMaskHelper.cpp:133: */
Move these two into getTexture (to limit their scope) ?
Can they go inside the GR_COMPRESS_ALPHA_MASK block ?

https://codereview.chromium.org/398603004/diff/20001/src/gpu/GrSWMaskHelper.c...
src/gpu/GrSWMaskHelper.cpp:148: 
Move this into the GR_COMPRESS_ALPHA_MASK block ?

https://codereview.chromium.org/398603004/diff/20001/src/gpu/GrSWMaskHelper.c...
src/gpu/GrSWMaskHelper.cpp:173: void
GrSWMaskHelper::compressTextureData(GrTexture *texture, const GrTextureDesc&
desc) {
// SkASSERT(GrPixelConfigIsCompressed(desc.fConfig)); ?

https://codereview.chromium.org/398603004/diff/20001/src/gpu/GrSWMaskHelper.c...
src/gpu/GrSWMaskHelper.cpp:174: SkTextureCompressor::Format format =
SkTextureCompressor::kLATC_Format;
// Compress to the format required by 'texture' ?

https://codereview.chromium.org/398603004/diff/20001/src/gpu/GrSWMaskHelper.h
File src/gpu/GrSWMaskHelper.h (right):

https://codereview.chromium.org/398603004/diff/20001/src/gpu/GrSWMaskHelper.h...
src/gpu/GrSWMaskHelper.h:109: // Compresses the bitmap stored in fBM and sends
the compressed data
in texture -> in a texture ?

[krajcevski, 2014-07-16 13:43:03]

https://codereview.chromium.org/398603004/diff/20001/src/gpu/GrSWMaskHelper.cpp
File src/gpu/GrSWMaskHelper.cpp (right):

https://codereview.chromium.org/398603004/diff/20001/src/gpu/GrSWMaskHelper.c...
src/gpu/GrSWMaskHelper.cpp:133: */
On 2014/07/16 12:13:23, robertphillips wrote:
> Move these two into getTexture (to limit their scope) ?
> Can they go inside the GR_COMPRESS_ALPHA_MASK block ?

Done.

https://codereview.chromium.org/398603004/diff/20001/src/gpu/GrSWMaskHelper.c...
src/gpu/GrSWMaskHelper.cpp:148: 
On 2014/07/16 12:13:23, robertphillips wrote:
> Move this into the GR_COMPRESS_ALPHA_MASK block ?

Hrm, it doesn't need to be. The passed config should be texturable, but if we're
not compressing then it'll just be a no-op.

https://codereview.chromium.org/398603004/diff/20001/src/gpu/GrSWMaskHelper.c...
src/gpu/GrSWMaskHelper.cpp:173: void
GrSWMaskHelper::compressTextureData(GrTexture *texture, const GrTextureDesc&
desc) {
On 2014/07/16 12:13:23, robertphillips wrote:
> // SkASSERT(GrPixelConfigIsCompressed(desc.fConfig)); ?

Done.

https://codereview.chromium.org/398603004/diff/20001/src/gpu/GrSWMaskHelper.c...
src/gpu/GrSWMaskHelper.cpp:174: SkTextureCompressor::Format format =
SkTextureCompressor::kLATC_Format;
On 2014/07/16 12:13:23, robertphillips wrote:
> // Compress to the format required by 'texture' ?

Done.

https://codereview.chromium.org/398603004/diff/20001/src/gpu/GrSWMaskHelper.h
File src/gpu/GrSWMaskHelper.h (right):

https://codereview.chromium.org/398603004/diff/20001/src/gpu/GrSWMaskHelper.h...
src/gpu/GrSWMaskHelper.h:109: // Compresses the bitmap stored in fBM and sends
the compressed data
On 2014/07/16 12:13:23, robertphillips wrote:
> in texture -> in a texture ?

Done.

[krajcevski, 2014-07-16 16:23:16]

The CQ bit was checked by krajcevski@google.com

[krajcevski, 2014-07-16 16:23:16]

The CQ bit was unchecked by krajcevski@google.com

[krajcevski, 2014-07-16 16:23:16]

The CQ bit was checked by krajcevski@google.com

[commit-bot: I haz the power, 2014-07-16 16:23:32]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/krajcevski@google.com/398603004/60001

[commit-bot: I haz the power, 2014-07-16 20:26:46]

Change committed as b577c55a13850b8f4739e14b10d426a3ec6b05d0