Refactor safe-browsing build-config definitions.

build/common.gypi

Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 177cc99cbd7b1613336b59084eb5a73e7729f194..4f619c282a3b5b82ae9949fe4e894a2489a68f32 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2852,6 +2852,25 @@
       ['video_hole==1', {
         'defines': ['VIDEO_HOLE=1'],
       }],
+
+      # SAFE_BROWSING_SERVICE - browser manages a safe-browsing service.
+      # SAFE_BROWSING_DATABASE - service manages a local database.
+      # SAFE_BROWSING_CSD - enable client-side phishing detection.
+      ['safe_browsing==1', {
+        'defines': [
+          'FULL_SAFE_BROWSING',
+          'SAFE_BROWSING_CSD',
+          'SAFE_BROWSING_DATABASE',
+          'SAFE_BROWSING_SERVICE',
+        ],
+      }],
+      # TODO(shess): I believe this case is no longer in use.

[mattm, 2014/07/31 00:51:43]

iOS build is a mystery to me, but I thought they still use safe_browsing=2

[Lei Zhang, 2014/07/31 00:54:45]

Isn't it 0? See build/common.gypi:762.

[mattm, 2014/07/31 00:59:44]

They must be overriding it somewhere in the internal build.

[Scott Hess - ex-Googler, 2014/07/31 20:50:14]

IMHO, anything people rely on in the Chromium tree needs to be anchored by a
test and/or comments that are in the Chromium tree.  I'll loop in rohit just in
case I'm about to set their world on fire.

[I _think_ this change should break anyone, though, as FULL_SAFE_BROWSING and
MOBILE_SAFE_BROWSING continue to be defined.  Long term I'd prefer to shift away
from ambiguous-bag-of-features defines, though.]

+      ['safe_browsing==2', {
+        'defines': [
+          'MOBILE_SAFE_BROWSING',
+          'SAFE_BROWSING_SERVICE',
+        ],
+      }],
     ],  # conditions for 'target_defaults'
     'target_conditions': [
       ['<(use_openssl)==1', {