Refactor safe-browsing build-config definitions.

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 2834 matching lines @@
       }],
       ['enable_hangout_services_extension==1', {
         'defines': ['ENABLE_HANGOUT_SERVICES_EXTENSION=1'],
       }],
       ['enable_ipc_fuzzer==1', {
         'defines': ['ENABLE_IPC_FUZZER=1'],
       }],
       ['video_hole==1', {
         'defines': ['VIDEO_HOLE=1'],
       }],
+
+      # SAFE_BROWSING_SERVICE - browser manages a safe-browsing service.
+      # SAFE_BROWSING_DATABASE - service manages a local database.
+      # SAFE_BROWSING_CSD - enable client-side phishing detection.
+      ['safe_browsing==1', {
+        'defines': [
+          'FULL_SAFE_BROWSING',
+          'SAFE_BROWSING_CSD',
+          'SAFE_BROWSING_DATABASE',
+          'SAFE_BROWSING_SERVICE',
+        ],
+      }],
+      # TODO(shess): I believe this case is no longer in use.

[mattm, 2014/07/31 00:51:43]

iOS build is a mystery to me, but I thought they still use safe_browsing=2

[Lei Zhang, 2014/07/31 00:54:45]

Isn't it 0? See build/common.gypi:762.

[mattm, 2014/07/31 00:59:44]

They must be overriding it somewhere in the internal build.

[Scott Hess - ex-Googler, 2014/07/31 20:50:14]

IMHO, anything people rely on in the Chromium tree needs to be anchored by a
test and/or comments that are in the Chromium tree.  I'll loop in rohit just in
case I'm about to set their world on fire.

[I _think_ this change should break anyone, though, as FULL_SAFE_BROWSING and
MOBILE_SAFE_BROWSING continue to be defined.  Long term I'd prefer to shift away
from ambiguous-bag-of-features defines, though.]

+      ['safe_browsing==2', {
+        'defines': [
+          'MOBILE_SAFE_BROWSING',
+          'SAFE_BROWSING_SERVICE',
+        ],
+      }],
     ],  # conditions for 'target_defaults'
     'target_conditions': [
       ['<(use_openssl)==1', {
         'defines': ['USE_OPENSSL=1'],
       }],
       ['<(use_openssl_certs)==1', {
         'defines': ['USE_OPENSSL_CERTS=1'],
       }],
       ['>(nacl_untrusted_build)==1', {
         'defines': [
@@ skipping 2807 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }