Refactor safe-browsing build-config definitions.

chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.cc

Index: chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.cc
diff --git a/chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.cc b/chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.cc
index 7b1fe0930180d6d5919c5850ca146464e844d507..f99259c48ceaa8da499a8d0403097b97312862fa 100644
--- a/chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.cc
+++ b/chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.cc
@@ -5,7 +5,8 @@
 #include "chrome/browser/renderer_host/safe_browsing_resource_throttle_factory.h"
 
 #include "content/public/browser/resource_context.h"
-#if defined(FULL_SAFE_BROWSING)
+
+#if defined(SAFE_BROWSING_DATABASE)
 #include "chrome/browser/renderer_host/safe_browsing_resource_throttle.h"
 #endif
 
@@ -27,15 +28,19 @@ ResourceThrottle* SafeBrowsingResourceThrottleFactory::Create(
     content::ResourceContext* resource_context,
     bool is_subresource,
     SafeBrowsingService* service) {
+#if defined(SAFE_BROWSING_SERVICE)
   if (factory_)
     return factory_->CreateResourceThrottle(
         request, resource_context, is_subresource, service);
 
-#if defined(FULL_SAFE_BROWSING)
+#if defined(SAFE_BROWSING_DATABASE)
+  // Throttle consults a local database before proceeding.
   return new SafeBrowsingResourceThrottle(request, is_subresource, service);
-#elif defined(MOBILE_SAFE_BROWSING)
+#else
   return NULL;
+#endif  // SAFE_BROWSING_DATABASE
+
 #else
 #error Need to define {FULL|MOBILE} SAFE_BROWSING mode.

[mattm, 2014/07/31 00:51:43]

update error message?

[Scott Hess - ex-Googler, 2014/07/31 20:50:14]

Done.

-#endif
+#endif  // SAFE_BROWSING_SERVICE
 }